Switch AppBannerManager on use of Unretained to use it's weakptr factory.

chrome/browser/android/banners/app_banner_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/banners/app_banner_manager.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 120 matching lines @@
     const GURL& validated_url) {
   if (render_frame_host->GetParent())
     return;
   validated_url_ = validated_url;
 
   // A secure scheme is required to show banners, so exit early if we see the
   // URL is invalid.
   if (!validated_url_.SchemeIsSecure() && !gDisableSecureCheckForTesting)
     return;
 
-  // See if the page has a manifest. Using Unretained(this) here is safe as the
-  // lifetime of this object extends beyond the lifetime of the web_contents(),
-  // and when web_contents() is destroyed it will call OnDidGetManifest.
+  // See if the page has a manifest.
   web_contents()->GetManifest(base::Bind(&AppBannerManager::OnDidGetManifest,
-                                         base::Unretained(this)));
+                                         weak_factory_.GetWeakPtr()));
 }
 
 void AppBannerManager::OnDidGetManifest(const content::Manifest& manifest) {
   if (web_contents()->IsBeingDestroyed())
     return;
 
   if (manifest.IsEmpty()
       || !manifest.start_url.is_valid()
       || (manifest.name.is_null() && manifest.short_name.is_null())) {
     // No usable manifest, see if there is a play store meta tag.
@@ skipping 216 matching lines @@
 void DisableSecureSchemeCheckForTesting(JNIEnv* env, jclass clazz) {
   gDisableSecureCheckForTesting = true;
 }
 
 // Register native methods
 bool RegisterAppBannerManager(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace banners