Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 942583005: Revert of Make sure MessagePortService is used in a thread safe manner. (Closed)

Created:
5 years, 10 months ago by kaliamoorthi
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make sure MessagePortService is used in a thread safe manner. (patchset #4 id:80001 of https://codereview.chromium.org/937503003/) Reason for revert: This CL is suspected to cause the Win7 test (dbg) failures. Original issue's description: > Added DCHECKs to all public methods of MessagePortService to make sure it is used in a thread safe manner. > > BUG=459115 > > Committed: https://crrev.com/c2d9552dde5a7dd05dc63e744c71f497f0120306 > Cr-Commit-Position: refs/heads/master@{#317178} TBR=creis@chromium.org,sgurun@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459115 Committed: https://crrev.com/60583adc54a6b043dc0b812f10869801eb0da0b4 Cr-Commit-Position: refs/heads/master@{#317299}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M content/browser/message_port_service.cc View 12 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kaliamoorthi
Created Revert of Make sure MessagePortService is used in a thread safe manner.
5 years, 10 months ago (2015-02-20 12:19:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942583005/1
5 years, 10 months ago (2015-02-20 12:20:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 12:21:12 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/60583adc54a6b043dc0b812f10869801eb0da0b4 Cr-Commit-Position: refs/heads/master@{#317299}
5 years, 10 months ago (2015-02-20 12:22:10 UTC) #4
kaliamoorthi
5 years, 10 months ago (2015-02-20 14:07:25 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/947483002/ by kaliamoorthi@chromium.org.

The reason for reverting is: This does not seem to cause the problem..

Powered by Google App Engine
This is Rietveld 408576698