Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: content/browser/message_port_service.cc

Issue 942583005: Revert of Make sure MessagePortService is used in a thread safe manner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/message_port_service.cc
diff --git a/content/browser/message_port_service.cc b/content/browser/message_port_service.cc
index 9ee4d70c24490c578e3335454adb471f5249dde7..3b7ef7e5eff9047c126fb259cbf406ce3a3bdfbf 100644
--- a/content/browser/message_port_service.cc
+++ b/content/browser/message_port_service.cc
@@ -63,7 +63,7 @@
void MessagePortService::UpdateMessagePort(int message_port_id,
MessagePortDelegate* delegate,
int routing_id) {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
if (!message_ports_.count(message_port_id)) {
NOTREACHED();
return;
@@ -76,7 +76,6 @@
void MessagePortService::OnMessagePortDelegateClosing(
MessagePortDelegate* delegate) {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
// Check if the (possibly) crashed process had any message ports.
for (MessagePorts::iterator iter = message_ports_.begin();
iter != message_ports_.end();) {
@@ -90,7 +89,7 @@
void MessagePortService::Create(int route_id,
MessagePortDelegate* delegate,
int* message_port_id) {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
*message_port_id = ++next_message_port_id_;
MessagePort port;
@@ -105,7 +104,6 @@
}
void MessagePortService::Destroy(int message_port_id) {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(message_port_id)) {
NOTREACHED();
return;
@@ -118,7 +116,6 @@
void MessagePortService::Entangle(int local_message_port_id,
int remote_message_port_id) {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(local_message_port_id) ||
!message_ports_.count(remote_message_port_id)) {
NOTREACHED();
@@ -135,7 +132,6 @@
int sender_message_port_id,
const base::string16& message,
const std::vector<int>& sent_message_port_ids) {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(sender_message_port_id)) {
NOTREACHED();
return;
@@ -199,7 +195,6 @@
}
void MessagePortService::QueueMessages(int message_port_id) {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(message_port_id)) {
NOTREACHED();
return;
@@ -216,7 +211,6 @@
void MessagePortService::SendQueuedMessages(
int message_port_id,
const QueuedMessages& queued_messages) {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(message_port_id)) {
NOTREACHED();
return;
@@ -246,7 +240,6 @@
}
void MessagePortService::SendQueuedMessagesIfPossible(int message_port_id) {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(message_port_id)) {
NOTREACHED();
return;
@@ -264,7 +257,6 @@
}
void MessagePortService::HoldMessages(int message_port_id) {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(message_port_id)) {
NOTREACHED();
return;
@@ -279,7 +271,6 @@
}
void MessagePortService::ClosePort(int message_port_id) {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(message_port_id)) {
NOTREACHED();
return;
@@ -299,7 +290,6 @@
}
void MessagePortService::ReleaseMessages(int message_port_id) {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
if (!message_ports_.count(message_port_id)) {
NOTREACHED();
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698