Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 942553002: Make element.style["color"] work in Sky (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
esprehn, ojan
CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make element.style["color"] work in Sky This CL makes CSSStyleDeclaration a bit less painful to use by replacing the crazy Java-style APIs with overloading operator[] and operator[]=. R=esprehn@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0929cf323a89b7c3a0efa4e1ab353263c31016c2

Patch Set 1 #

Total comments: 8

Patch Set 2 : Add back removeProperty #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -90 lines) Patch
M sky/engine/bindings/scripts/dart_interface.py View 3 chunks +16 lines, -9 lines 0 comments Download
M sky/engine/bindings/scripts/templates/interface_base_cpp.template View 3 chunks +6 lines, -7 lines 0 comments Download
M sky/engine/bindings/scripts/templates/interface_cpp.template View 4 chunks +89 lines, -5 lines 0 comments Download
M sky/engine/bindings/scripts/templates/interface_dart.template View 1 chunk +8 lines, -0 lines 0 comments Download
M sky/engine/core/animation/AnimationNodeTiming.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/AnimationNodeTiming.cpp View 1 chunk +6 lines, -12 lines 0 comments Download
M sky/engine/core/animation/Timing.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSStyleDeclaration.idl View 1 1 chunk +7 lines, -31 lines 0 comments Download
M sky/engine/core/frame/Window.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/tests/layout/document-elementFromPoint.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/lowlevel/bug-438036.sky View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/tests/lowlevel/classlist.sky View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/tests/lowlevel/style-basic.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/lowlevel/style-specificity.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/styles/border-parsing.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/styles/inline-style.sky View 1 chunk +2 lines, -3 lines 0 comments Download
M sky/tests/styles/media-queries.sky View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
abarth-chromium
5 years, 10 months ago (2015-02-19 19:00:01 UTC) #1
esprehn
You also got rid of removeProperty, I think we need that or we need to ...
5 years, 10 months ago (2015-02-19 20:12:48 UTC) #3
abarth-chromium
https://codereview.chromium.org/942553002/diff/1/sky/engine/bindings/scripts/templates/interface_cpp.template File sky/engine/bindings/scripts/templates/interface_cpp.template (right): https://codereview.chromium.org/942553002/diff/1/sky/engine/bindings/scripts/templates/interface_cpp.template#newcode12 sky/engine/bindings/scripts/templates/interface_cpp.template:12: {{cpp_class}}* /* FIXME(vsm): Remove this. */ ALLOW_UNUSED receiver = ...
5 years, 10 months ago (2015-02-19 20:19:58 UTC) #4
esprehn
lgtm w/ removeProperty added back.
5 years, 10 months ago (2015-02-19 20:27:03 UTC) #5
abarth-chromium
Thanks!
5 years, 10 months ago (2015-02-19 20:29:30 UTC) #6
abarth-chromium
5 years, 10 months ago (2015-02-19 21:06:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0929cf323a89b7c3a0efa4e1ab353263c31016c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698