Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: sky/engine/bindings/scripts/templates/interface_base_cpp.template

Issue 942553002: Make element.style["color"] work in Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Add back removeProperty Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/bindings/scripts/templates/interface_base_cpp.template
diff --git a/sky/engine/bindings/scripts/templates/interface_base_cpp.template b/sky/engine/bindings/scripts/templates/interface_base_cpp.template
index b1d7f11fe53da96b7552b14026b13a6174f19bd0..6d569123deac6cb02d47c201f3486f9b9060544b 100644
--- a/sky/engine/bindings/scripts/templates/interface_base_cpp.template
+++ b/sky/engine/bindings/scripts/templates/interface_base_cpp.template
@@ -72,7 +72,8 @@ namespace {{dart_class}}Internal {
{% endif %}
{% endfor %}
-{# Special operations (methods) #}
+ {% block named_property_getter %}{% endblock %}
+ {% block named_property_setter %}{% endblock %}
{% block indexed_property_getter %}{% endblock %}
}
@@ -108,10 +109,9 @@ Dart_NativeFunction {{dart_class}}::Resolver(Dart_Handle nameHandle, int argumen
{% endfor %}
{# Special operations (methods) #}
{# TODO(terry): Only emit indexed getter for DataTransferItemList; emit for interfaces. #}
- {% block indexed_property_getter_resolver %}{% endblock %}
- {% if dart_class == 'DartCSSStyleDeclaration' %}
- {% block named_property_getter_resolver %}{% endblock %}
- {% endif %}
+{% block indexed_property_getter_resolver %}{% endblock %}
+{% block named_property_getter_resolver %}{% endblock %}
+{% block named_property_setter_resolver %}{% endblock %}
return 0;
}
@@ -135,9 +135,8 @@ const uint8_t* {{dart_class}}::Symbolizer(Dart_NativeFunction native_function)
{% for method in methods if not method.suppressed %}
{{generate_symbolizer_body(dart_class, interface_name, method) | indent(4)}}
{% endfor %}
- {% if dart_class == 'DartCSSStyleDeclaration' %}
{% block generate_symbolizer_named_property_getter %}{% endblock %}
- {% endif %}
+{% block generate_symbolizer_named_property_setter %}{% endblock %}
{% block generate_symbolizer_indexed_property_getter %}{% endblock %}
return 0;
}
« no previous file with comments | « sky/engine/bindings/scripts/dart_interface.py ('k') | sky/engine/bindings/scripts/templates/interface_cpp.template » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698