Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: Source/core/dom/Attr.idl

Issue 942283002: Sync the Attr interface with the spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: crbug Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Attr.idl
diff --git a/Source/core/dom/Attr.idl b/Source/core/dom/Attr.idl
index 3d8e960dd2712b931d450d69865004321bed2c61..f4aca2705f71a0674619c824fe8867f20f83a201 100644
--- a/Source/core/dom/Attr.idl
+++ b/Source/core/dom/Attr.idl
@@ -18,29 +18,25 @@
* Boston, MA 02110-1301, USA.
*/
-interface Attr : Node {
-
- // DOM Level 1
+// https://dom.spec.whatwg.org/#interface-attr
+// FIXME: Attr should not inherit from Node. crbug.com/305105
+interface Attr : Node {
+ readonly attribute DOMString? namespaceURI;
+ readonly attribute DOMString? prefix;
+ // FIXME: localName/name/value/nodeValue/textContent should not be nullable.
+ readonly attribute DOMString? localName;
readonly attribute DOMString? name;
-
- [MeasureAs=AttributeSpecified] readonly attribute boolean specified;
-
[ImplementedAs=valueForBindings, CustomElementCallbacks] attribute DOMString? value;
- [ImplementedAs=valueForBindings, MeasureAs=AttrNodeValue] attribute DOMString? nodeValue;
- [ImplementedAs=valueForBindings, MeasureAs=AttrTextContent] attribute DOMString? textContent;
-
- // DOM Level 2
+ [ImplementedAs=valueForBindings, MeasureAs=AttrNodeValue] attribute DOMString? nodeValue; // legacy alias of .value
+ [ImplementedAs=valueForBindings, MeasureAs=AttrTextContent] attribute DOMString? textContent; // legacy alias of .value
+ // FIXME: ownerElement should be nullable.
[MeasureAs=AttributeOwnerElement] readonly attribute Element ownerElement;
- // DOM 4
-
- readonly attribute DOMString? prefix;
- readonly attribute DOMString? namespaceURI;
- readonly attribute DOMString? localName;
+ [MeasureAs=AttributeSpecified] readonly attribute boolean specified; // useless; always returns true
- // https://www.w3.org/Bugs/Public/show_bug.cgi?id=26609
+ // FIXME: Attr should not have any child nodes. crbug.com/305105
[MeasureAs=AttrChildAccess] readonly attribute NodeList childNodes;
[MeasureAs=AttrChildAccess] readonly attribute Node firstChild;
[MeasureAs=AttrChildAccess] readonly attribute Node lastChild;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698