Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4000)

Unified Diff: chrome/common/extensions/docs/server2/PRESUBMIT.py

Issue 942263002: Add Pylint for docs server. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/docs/server2/PRESUBMIT.py
diff --git a/chrome/common/extensions/docs/server2/PRESUBMIT.py b/chrome/common/extensions/docs/server2/PRESUBMIT.py
index b4332e203e920414cb1a2a9094e607486c3ae8eb..57fc5516db2c96645a93bbbd87ffecbd078344d7 100644
--- a/chrome/common/extensions/docs/server2/PRESUBMIT.py
+++ b/chrome/common/extensions/docs/server2/PRESUBMIT.py
@@ -85,12 +85,16 @@ def _CheckYamlConsistency(input_api, output_api):
def _RunPresubmit(input_api, output_api):
_BuildServer(input_api)
- return (
- _WarnIfAppYamlHasntChanged(input_api, output_api) +
- _CheckYamlConsistency(input_api, output_api) +
- input_api.canned_checks.RunUnitTestsInDirectory(
+
+ results = []
+
+ results += input_api.canned_checks.RunPylint(input_api, output_api)
+ results += _WarnIfAppYamlHasntChanged(input_api, output_api)
+ results += _CheckYamlConsistency(input_api, output_api)
+ results += input_api.canned_checks.RunUnitTestsInDirectory(
input_api, output_api, '.', whitelist=WHITELIST, blacklist=BLACKLIST)
- )
+
+ return results
not at google - send to devlin 2015/02/23 18:43:30 Could you leave the formatting as before?
tfarina 2015/02/23 20:17:55 Any reason why? I assume you are talking about: r
not at google - send to devlin 2015/02/23 20:34:19 Yes. The reason is because it's an unnecessary cos
tfarina 2015/02/23 20:39:21 Indeed! Done.
def CheckChangeOnUpload(input_api, output_api):
return _RunPresubmit(input_api, output_api)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698