Add Pylint for docs server.

chrome/common/extensions/docs/server2/PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Presubmit script for changes affecting extensions docs server
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into depot_tools.
 """
 
@@ skipping 67 matching lines @@
       input_api.ReadFile(cron_yaml_path), key='target')
 
   if app_yaml_version == cron_yaml_version:
     return []
   return [output_api.PresubmitError(
       'Versions of app.yaml (%s) and cron.yaml (%s) must match' % (
           app_yaml_version, cron_yaml_version))]
 
 def _RunPresubmit(input_api, output_api):
   _BuildServer(input_api)
-  return (
-      _WarnIfAppYamlHasntChanged(input_api, output_api) +
-      _CheckYamlConsistency(input_api, output_api) +
-      input_api.canned_checks.RunUnitTestsInDirectory(
+
+  results = []
+
+  results += input_api.canned_checks.RunPylint(input_api, output_api)
+  results += _WarnIfAppYamlHasntChanged(input_api, output_api)
+  results += _CheckYamlConsistency(input_api, output_api)
+  results += input_api.canned_checks.RunUnitTestsInDirectory(
           input_api, output_api, '.', whitelist=WHITELIST, blacklist=BLACKLIST)
-  )
+
+  return results

[not at google - send to devlin, 2015/02/23 18:43:30]

Could you leave the formatting as before?

[tfarina, 2015/02/23 20:17:55]

Any reason why? I assume you are talking about:

return ( ... + ... ) 

vs

results += 

?

[not at google - send to devlin, 2015/02/23 20:34:19]

Yes. The reason is because it's an unnecessary cosmetic change.

[tfarina, 2015/02/23 20:39:21]

Indeed! Done.

 
 def CheckChangeOnUpload(input_api, output_api):
   return _RunPresubmit(input_api, output_api)
 
 def CheckChangeOnCommit(input_api, output_api):
   return _RunPresubmit(input_api, output_api)