Files.app: fix some closure compilation issues to unblock new compiler roll.

Files.app: fix some closure compilation issues to unblock new compiler roll.

R=tbreisacher@chromium.org
TBR=fukino@chromium.org
BUG=393873
Committed: https://crrev.com/2e33d2262d0963cd17fc8396138b2460ab5d413a
Cr-Commit-Position: refs/heads/master@{#317454}

[Dan Beam, 2015-02-20 23:00:20]

there ended up being a lot more than this, but these are the fairly safe ones...

[Tyler Breisacher (Chromium), 2015-02-20 23:05:22]

lgtm

https://codereview.chromium.org/942193002/diff/1/ui/webui/resources/js/cr/ui/...
File ui/webui/resources/js/cr/ui/dialogs.js (right):

https://codereview.chromium.org/942193002/diff/1/ui/webui/resources/js/cr/ui/...
ui/webui/resources/js/cr/ui/dialogs.js:92: /** @private {Function|undefined} */
It's a little messy to allow both null and undefined, but it happens.

[Dan Beam, 2015-02-20 23:06:21]

https://codereview.chromium.org/942193002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/background/js/drive_sync_handler.js (right):

https://codereview.chromium.org/942193002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/background/js/drive_sync_handler.js:178:
this.item_.progressMax = status.total || 0;
matches the defaults set in
https://code.google.com/p/chromium/codesearch#chromium/src/ui/file_manager/fi...

https://codereview.chromium.org/942193002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/background/js/volume_manager.js (right):

https://codereview.chromium.org/942193002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/background/js/volume_manager.js:690:
event.volumeMetadata.sourcePath || '');
is actually optional:
https://code.google.com/p/chromium/codesearch#chromium/src/out/Debug/gen/chro...

https://codereview.chromium.org/942193002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/app_installer.js (right):

https://codereview.chromium.org/942193002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/app_installer.js:50:
this.onInstallCompleted_(chrome.runtime.lastError);
mildly bad externs I'm too lazy to update:

  /** @type {!Object|undefined} */
  chrome.runtime.lastError = {};

  /**
   * @type {string|undefined}
   */
  chrome.runtime.lastError.message;

https://codereview.chromium.org/942193002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/file_manager.js (right):

https://codereview.chromium.org/942193002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/file_manager.js:643: this.tracker_ =
this.backgroundPage_.background.tracker;
should be initialized here

https://codereview.chromium.org/942193002/diff/1/ui/webui/resources/js/cr/ui/...
File ui/webui/resources/js/cr/ui/dialogs.js (right):

https://codereview.chromium.org/942193002/diff/1/ui/webui/resources/js/cr/ui/...
ui/webui/resources/js/cr/ui/dialogs.js:92: /** @private {Function|undefined} */
On 2015/02/20 23:05:22, Tyler Breisacher (Chromium) wrote:
> It's a little messy to allow both null and undefined, but it happens.

Acknowledged.

[Dan Beam, 2015-02-20 23:07:01]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-02-20 23:07:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/942193002/1

[commit-bot: I haz the power, 2015-02-21 00:46:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-21 00:47:19]

Patchset 1 (id:??) landed as
https://crrev.com/2e33d2262d0963cd17fc8396138b2460ab5d413a
Cr-Commit-Position: refs/heads/master@{#317454}