Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: ui/file_manager/file_manager/background/js/app_window_wrapper.js

Issue 942193002: Files.app: fix some closure compilation issues to unblock new compiler roll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/background/js/app_window_wrapper.js
diff --git a/ui/file_manager/file_manager/background/js/app_window_wrapper.js b/ui/file_manager/file_manager/background/js/app_window_wrapper.js
index 229fae38ee1f2cd9c22cc11d104a8654571ce8cc..d3dc47905416b27ecb0f31d661b95a6fb0b00ac5 100644
--- a/ui/file_manager/file_manager/background/js/app_window_wrapper.js
+++ b/ui/file_manager/file_manager/background/js/app_window_wrapper.js
@@ -23,7 +23,8 @@ function AppWindowWrapper(url, id, options) {
this.url_ = url;
this.id_ = id;
// Do deep copy for the template of options to assign customized params later.
- this.options_ = JSON.parse(JSON.stringify(options));
+ this.options_ = /** @type chrome.app.window.CreateWindowOptions */(
+ JSON.parse(JSON.stringify(options)));
this.window_ = null;
this.appState_ = null;
this.openingOrOpened_ = false;
@@ -304,7 +305,7 @@ SingletonAppWindowWrapper.prototype.reopen = function(opt_callback) {
}
try {
- var appState = JSON.parse(value);
+ var appState = assertInstanceof(JSON.parse(value), Object);
} catch (e) {
console.error('Corrupt launch data for ' + this.id_, value);
opt_callback && opt_callback();

Powered by Google App Engine
This is Rietveld 408576698