Source/web/ContextMenuClientImpl.cpp - Issue 942183005: Revert of Added code to fix visibility of select all option in context menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ContextMenuClientImpl.cpp

Issue 942183005: Revert of Added code to fix visibility of select all option in context menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ContextMenuClientImpl.cpp

diff --git a/Source/web/ContextMenuClientImpl.cpp b/Source/web/ContextMenuClientImpl.cpp

index 6579f6e80dd9b70bd0f8e4d5b7461cae9cd200d0..517305b7570e797255ab3ac8d6ee9ef5271aafa6 100644

--- a/Source/web/ContextMenuClientImpl.cpp

+++ b/Source/web/ContextMenuClientImpl.cpp

@@ -219,10 +219,8 @@

data.editFlags |= WebContextMenuData::CanPaste;

if (toLocalFrame(m_webView->focusedWebCoreFrame())->editor().canDelete())

data.editFlags |= WebContextMenuData::CanDelete;

- if (isHTMLTextFormControlElement(r.innerNonSharedNode())) {

- if (!toHTMLTextFormControlElement(r.innerNonSharedNode())->value().isEmpty())

- data.editFlags |= WebContextMenuData::CanSelectAll;

- }

+ // We can always select all...

+ data.editFlags |= WebContextMenuData::CanSelectAll;

data.editFlags |= WebContextMenuData::CanTranslate;

// Links, Images, Media tags, and Image/Media-Links take preference over

« no previous file with comments | « no previous file | no next file » | no next file with comments »