Issue 942183005: Revert of Added code to fix visibility of select all option in context menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 942183005: Revert of Added code to fix visibility of select all option in context menu. (Closed)

Created:
5 years, 10 months ago by ankitkumar

Modified:
5 years, 10 months ago

Reviewers:
darin (slow to review), esprehn, ankit, aelias_OOO_until_Jul13, abarth-chromium

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Revert of Added code to fix visibility of select all option in context menu. (patchset #3 id:40001 of https://codereview.chromium.org/402403003/) Reason for revert: This CL is causing Issue 438135 and Issue 450540. So reverting this. Original issue's description: > Added code to fix visibility of select all option in context menu. > > If context menu is appearing on some input field. Select all option > should appear only if some text is present inside input field. > > BUG=395994 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179636 TBR=darin@chromium.org,aelias@chromium.org,abarth@chromium.org,esprehn@chromium.org,ankit2.kumar@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=395994 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190714

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	Source/web/ContextMenuClientImpl.cpp	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

ankitkumar

Created Revert of Added code to fix visibility of select all option in context menu.

5 years, 10 months ago (2015-02-24 03:59:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942183005/1

5 years, 10 months ago (2015-02-24 04:00:05 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-24 04:01:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190714