Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 9421010: Allow app launch URLs to be localized. (Closed)

Created:
8 years, 10 months ago by Mihai Parparita -not on Chrome
Modified:
8 years, 10 months ago
Reviewers:
jstritar
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit #

Messages

Total messages: 5 (0 generated)
Mihai Parparita -not on Chrome
8 years, 10 months ago (2012-02-17 22:32:42 UTC) #1
jstritar
LGTM http://codereview.chromium.org/9421010/diff/1/chrome/common/extensions/extension_manifests_unittest.cc File chrome/common/extensions/extension_manifests_unittest.cc (right): http://codereview.chromium.org/9421010/diff/1/chrome/common/extensions/extension_manifests_unittest.cc#newcode66 chrome/common/extensions/extension_manifests_unittest.cc:66: // Most unit tests don't need localization, and ...
8 years, 10 months ago (2012-02-21 15:44:03 UTC) #2
Mihai Parparita -not on Chrome
http://codereview.chromium.org/9421010/diff/1/chrome/common/extensions/extension_manifests_unittest.cc File chrome/common/extensions/extension_manifests_unittest.cc (right): http://codereview.chromium.org/9421010/diff/1/chrome/common/extensions/extension_manifests_unittest.cc#newcode66 chrome/common/extensions/extension_manifests_unittest.cc:66: // Most unit tests don't need localization, and they'll ...
8 years, 10 months ago (2012-02-21 17:46:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/9421010/6001
8 years, 10 months ago (2012-02-21 17:47:01 UTC) #4
commit-bot: I haz the power
8 years, 10 months ago (2012-02-21 19:11:17 UTC) #5
Change committed as 122848

Powered by Google App Engine
This is Rietveld 408576698