Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 941743002: Add a dedicated SSL protocol version metric. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: isherman comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « net/ssl/ssl_connection_status_flags.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 3c6996aac71069b7fb6b3be89f42ad48e4e9c4a8..09ea7f0ecb801f586f322ed45972a25031a2a878 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -16354,7 +16354,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="Net.ConnectionTypeCount3" enum="ConnectionType">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>davidben@chromium.org</owner>
<summary>
Each bucket is the number of successful connections of a particular type
that the user has had during the session.
@@ -17349,7 +17349,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</histogram>
<histogram name="Net.HadConnectionType3" enum="ConnectionType">
- <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <owner>davidben@chromium.org</owner>
<summary>
Each bucket is a boolean (0 or 1) indicating whether the user has had a
successful connection of that type during the session.
@@ -19713,7 +19713,10 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<histogram name="Net.SSL_CipherSuite" enum="SSLCipherSuite">
<owner>agl@chromium.org</owner>
<owner>rsleevi@chromium.org</owner>
- <summary>The SSL/TLS cipher suite that was negotiated.</summary>
+ <summary>
+ The SSL/TLS cipher suite that was negotiated. Recorded for each SSL/TLS
+ connection in the socket pool where Connect() succeeds.
+ </summary>
</histogram>
<histogram name="Net.SSL_Connection_Error" enum="NetErrorCodes">
@@ -19902,6 +19905,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<summary>Time saved by a speculative certificate vertification.</summary>
</histogram>
+<histogram name="Net.SSLVersion" enum="SSLOrQUICVersion">
Ilya Sherman 2015/02/19 22:08:23 Sorry, I see now that you were matching the conven
davidben 2015/02/19 22:19:07 Eh, we have some of both. It got chopped off by th
+ <owner>davidben@chromium.org</owner>
+ <summary>
+ The SSL/TLS version that was negotiated. Recorded for each SSL/TLS
+ connection in the socket pool where Connect() succeeds.
+ </summary>
+</histogram>
+
<histogram name="Net.TCP_Connection_Idle_Sockets">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>Number of idle sockets when the Connect() succeeded.</summary>
@@ -58731,6 +58742,16 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="3" label="NOT_EXPIRED_AND_DO_NOT_PROCEED"/>
</enum>
+<enum name="SSLOrQUICVersion" type="int">
+ <int value="0" label="Unknown"/>
+ <int value="1" label="SSL 2.0"/>
+ <int value="2" label="SSL 3.0"/>
+ <int value="3" label="TLS 1.0"/>
+ <int value="4" label="TLS 1.1"/>
+ <int value="5" label="TLS 1.2"/>
+ <int value="7" label="QUIC"/>
+</enum>
+
<enum name="SSLProtocolNegotiation" type="int">
<int value="1" label="ALPN, HTTP/1.1"/>
<int value="100" label="ALPN, SPDY 2.0"/>
« no previous file with comments | « net/ssl/ssl_connection_status_flags.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698