net/ssl/ssl_connection_status_flags.h - Issue 941743002: Add a dedicated SSL protocol version metric.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ssl/ssl_connection_status_flags.h

Issue 941743002: Add a dedicated SSL protocol version metric. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: isherman comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/ssl/ssl_connection_status_flags.h

diff --git a/net/ssl/ssl_connection_status_flags.h b/net/ssl/ssl_connection_status_flags.h

index d3bfed26f941c0609f4446a0d972b5205fc92146..5d806ae7d721a28e57932c0a20c13c71ebc2d8f5 100644

--- a/net/ssl/ssl_connection_status_flags.h

+++ b/net/ssl/ssl_connection_status_flags.h

@@ -37,7 +37,8 @@ enum {

};

// NOTE: the SSL version enum constants must be between 0 and

-// SSL_CONNECTION_VERSION_MASK, inclusive.

+// SSL_CONNECTION_VERSION_MASK, inclusive. These values are persisted to disk

+// and used in UMA, so they must remain stable.

enum {

SSL_CONNECTION_VERSION_UNKNOWN = 0, // Unknown SSL version.

SSL_CONNECTION_VERSION_SSL2 = 1,