Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 941503002: [l10n] Merge address_input_strings_translations.grdp. (Closed)

Created:
5 years, 10 months ago by please use gerrit instead
Modified:
5 years, 10 months ago
CC:
chromium-reviews, amineer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[l10n] Merge address_input_strings_translations.grdp. Merge address_input_strings_translations.grdp into address_input_strings.grd to follow the conventions in other grd files. The translations were originally separated to use the Java widget from libaddressinput, which Chrome since stopped using. This change makes translation scripts more reliable. BUG=459791 Committed: https://crrev.com/e24b3638790b0e84245985ab0bc2ec60b1619d06 Cr-Commit-Position: refs/heads/master@{#316988}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -62 lines) Patch
M chrome/app/address_input_strings.grd View 1 chunk +53 lines, -1 line 0 comments Download
D chrome/app/address_input_strings_translations.grdp View 1 chunk +0 lines, -61 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
please use gerrit instead
Evan, PTAL.
5 years, 10 months ago (2015-02-18 23:24:45 UTC) #2
Evan Stade
lgtm
5 years, 10 months ago (2015-02-19 01:04:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941503002/1
5 years, 10 months ago (2015-02-19 01:27:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/43719)
5 years, 10 months ago (2015-02-19 01:33:50 UTC) #7
please use gerrit instead
cpu, OWNERS PTAL. (The pre-submit script thinks that address_input_strings_translations.grdp does not match address_input_strings* regex, which ...
5 years, 10 months ago (2015-02-19 02:42:31 UTC) #9
cpu_(ooo_6.6-7.5)
lgtm
5 years, 10 months ago (2015-02-19 03:57:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941503002/1
5 years, 10 months ago (2015-02-19 03:57:41 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 04:00:38 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 04:01:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e24b3638790b0e84245985ab0bc2ec60b1619d06
Cr-Commit-Position: refs/heads/master@{#316988}

Powered by Google App Engine
This is Rietveld 408576698