Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 941443002: Fix use of multiple raster threads for software rendering. (Closed)

Created:
5 years, 10 months ago by vmiura
Modified:
5 years, 10 months ago
Reviewers:
reveman, no sievers, piman
CC:
reveman, chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix use of multiple raster threads for software rendering. By defaulting Threaded GPU Rasterization to ON I inadvertently disabled using more than 1 raster thread for Software rasterization everywhere. Fixing so IsThreadedGpuRasterizationEnabled() is only on if Gpu rasterization is enabled or forced, so this will currently only be on for Android. We'll need a better way to support multiple raster worker threads to turn on GPU rasterization on desktops, or to support multiple render threads on Android. BUG=454500 BUG=459760 Committed: https://crrev.com/f6ee6a2238d1ba7032a09d335cfc9a9d5d870232 Cr-Commit-Position: refs/heads/master@{#316949}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/browser/gpu/compositor_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
vmiura
PTAL
5 years, 10 months ago (2015-02-18 22:23:03 UTC) #2
no sievers
lgtm
5 years, 10 months ago (2015-02-18 22:40:41 UTC) #3
reveman
lgtm
5 years, 10 months ago (2015-02-18 22:45:24 UTC) #5
piman
lgtm3
5 years, 10 months ago (2015-02-18 23:06:07 UTC) #6
piman
lgtm3
5 years, 10 months ago (2015-02-18 23:06:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941443002/20001
5 years, 10 months ago (2015-02-18 23:44:07 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 01:11:59 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 01:12:31 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f6ee6a2238d1ba7032a09d335cfc9a9d5d870232
Cr-Commit-Position: refs/heads/master@{#316949}

Powered by Google App Engine
This is Rietveld 408576698