Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 941153003: Add dart_invoke to tonic for calls into App code. (Closed)

Created:
5 years, 10 months ago by rafaelw
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add dart_invoke to tonic for calls into App code. This patch adds utility functions which provide a single choke point for calling into sky application code. For now this is only serving the purpose of having a common trace event for calls into app code. R=abarth@chromium.org, abarth BUG= Committed: https://chromium.googlesource.com/external/mojo/+/37f9ce719aff8d8bdc5f053c78a381b45cb9f5be

Patch Set 1 #

Total comments: 1

Patch Set 2 : cr comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -7 lines) Patch
M sky/engine/bindings/builtin_natives.cc View 2 chunks +2 lines, -1 line 0 comments Download
M sky/engine/bindings/dart_callback.cc View 2 chunks +2 lines, -1 line 0 comments Download
M sky/engine/bindings/dart_event_listener.cc View 2 chunks +2 lines, -1 line 0 comments Download
M sky/engine/bindings/scheduled_action.cc View 2 chunks +2 lines, -1 line 0 comments Download
M sky/engine/core/dom/custom/custom_element.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M sky/engine/core/script/dart_controller.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M sky/engine/tonic/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_invoke.h View 1 1 chunk +23 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_invoke.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rafaelw
5 years, 10 months ago (2015-02-24 19:26:38 UTC) #2
abarth-chromium
LGTM https://codereview.chromium.org/941153003/diff/1/sky/engine/tonic/dart_invoke.cc File sky/engine/tonic/dart_invoke.cc (right): https://codereview.chromium.org/941153003/diff/1/sky/engine/tonic/dart_invoke.cc#newcode14 sky/engine/tonic/dart_invoke.cc:14: bool DartInvokeNamedAppClosure(Dart_Handle target, Dart_Handle name, Maybe DartInvokeApp for ...
5 years, 10 months ago (2015-02-24 19:28:20 UTC) #3
rafaelw
5 years, 10 months ago (2015-02-24 20:11:32 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
37f9ce719aff8d8bdc5f053c78a381b45cb9f5be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698