sky/engine/bindings/scheduled_action.cc - Issue 941153003: Add dart_invoke to tonic for calls into App code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/scheduled_action.cc

Issue 941153003: Add dart_invoke to tonic for calls into App code. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: cr comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/scheduled_action.cc

diff --git a/sky/engine/bindings/scheduled_action.cc b/sky/engine/bindings/scheduled_action.cc

index b03286965ab10dc8e9d321df9dff34cb856c8ffb..6d96466bfcd54d94bb630f897909fe2f15b212d8 100644

--- a/sky/engine/bindings/scheduled_action.cc

+++ b/sky/engine/bindings/scheduled_action.cc

@@ -7,6 +7,7 @@

#include "sky/engine/tonic/dart_api_scope.h"

#include "sky/engine/tonic/dart_error.h"

+#include "sky/engine/tonic/dart_invoke.h"

#include "sky/engine/tonic/dart_isolate_scope.h"

namespace blink {

@@ -24,7 +25,7 @@ void ScheduledAction::Execute(ExecutionContext*) {

return;

DartIsolateScope scope(closure_.dart_state()->isolate());

DartApiScope api_scope;

- LogIfError(Dart_InvokeClosure(closure_.value(), 0, nullptr));

+ DartInvokeAppClosure(closure_.value(), 0, nullptr);

}

} // namespace blink