Chromium Code Reviews| Index: chrome/browser/ui/views/elevation_icon_setter.h |
| diff --git a/chrome/browser/ui/views/elevation_icon_setter.h b/chrome/browser/ui/views/elevation_icon_setter.h |
| index 5e43e69f9b5cc7d1c90ec5303732f7073d7d75d4..782c6d3fb12ade4e5e16a31c5a4d69df54d4f0fb 100644 |
| --- a/chrome/browser/ui/views/elevation_icon_setter.h |
| +++ b/chrome/browser/ui/views/elevation_icon_setter.h |
| @@ -5,6 +5,7 @@ |
| #ifndef CHROME_BROWSER_UI_VIEWS_ELEVATION_ICON_SETTER_H_ |
| #define CHROME_BROWSER_UI_VIEWS_ELEVATION_ICON_SETTER_H_ |
| +#include "base/callback_forward.h" |
| #include "base/memory/scoped_ptr.h" |
| #include "base/memory/weak_ptr.h" |
| @@ -20,11 +21,12 @@ class LabelButton; |
| class ElevationIconSetter { |
| public: |
| // |button| must be guaranteed to be alive throughout this class' lifetime! |
| - explicit ElevationIconSetter(views::LabelButton* button); |
| + // |done_cb| will be called once the icon is set to the button. |
|
Peter Kasting
2015/02/23 21:58:35
Nit: How about this (see next comment regarding ar
xiaoling
2015/02/23 22:05:06
Done.
|
| + ElevationIconSetter(views::LabelButton* button, const base::Closure& done_cb); |
|
Peter Kasting
2015/02/23 21:58:35
Nit: The header and .cc disagree over the name of
xiaoling
2015/02/23 22:05:07
Done.
|
| ~ElevationIconSetter(); |
| private: |
| - void SetButtonIcon(scoped_ptr<SkBitmap> icon); |
| + void SetButtonIcon(const base::Closure& done_cb, scoped_ptr<SkBitmap> icon); |
| views::LabelButton* button_; |
| base::WeakPtrFactory<ElevationIconSetter> weak_factory_; |