Update global error bubble view's boundary (position and size) after loading elevation icon.

chrome/browser/ui/views/elevation_icon_setter.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_ELEVATION_ICON_SETTER_H_
 #define CHROME_BROWSER_UI_VIEWS_ELEVATION_ICON_SETTER_H_
 
+#include "base/callback_forward.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 
 class SkBitmap;
 
 namespace views {
 class LabelButton;
 }
 
 // On Windows, badges a button with a "UAC shield" icon to indicate that
 // clicking will trigger a UAC elevation prompt.  Does nothing on other
 // platforms.
 class ElevationIconSetter {
  public:
   // |button| must be guaranteed to be alive throughout this class' lifetime!
-  explicit ElevationIconSetter(views::LabelButton* button);
+  // |done_cb| will be called once the icon is set to the button.

[Peter Kasting, 2015/02/23 21:58:35]

Nit: How about this (see next comment regarding arg name):

|callback| will be called if the button icon is actually changed; callers should
pass a function which does a relayout on the view containing the button, to
ensure the button is correctly resized as necessary.

[xiaoling, 2015/02/23 22:05:06]

Done.

+  ElevationIconSetter(views::LabelButton* button, const base::Closure& done_cb);

[Peter Kasting, 2015/02/23 21:58:35]

Nit: The header and .cc disagree over the name of the second arg, and "cb"
arguably violates the Google style guide proscription against abbreviation.

I would just change all places in both files to use |callback| as the name.

[xiaoling, 2015/02/23 22:05:07]

Done.

   ~ElevationIconSetter();
 
  private:
-  void SetButtonIcon(scoped_ptr<SkBitmap> icon);
+  void SetButtonIcon(const base::Closure& done_cb, scoped_ptr<SkBitmap> icon);
 
   views::LabelButton* button_;
   base::WeakPtrFactory<ElevationIconSetter> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ElevationIconSetter);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_ELEVATION_ICON_SETTER_H_