added clock interstitial to chrome://interstitials

chrome/browser/ssl/ssl_blocking_page.h

Index: chrome/browser/ssl/ssl_blocking_page.h
diff --git a/chrome/browser/ssl/ssl_blocking_page.h b/chrome/browser/ssl/ssl_blocking_page.h
index dac5ab41a2f8050a7f99685cf017b820cde0716b..1cb90cc6c47263cc85c65632a0dad2a6e4d83268 100644
--- a/chrome/browser/ssl/ssl_blocking_page.h
+++ b/chrome/browser/ssl/ssl_blocking_page.h
@@ -70,7 +70,8 @@ class SSLBlockingPage : public SecurityInterstitialPage {
                   const net::SSLInfo& ssl_info,
                   const GURL& request_url,
                   int options_mask,
-                  const base::Callback<void(bool)>& callback);
+                  const base::Callback<void(bool)>& callback,
+                  const base::Time& time_triggered);

[Ryan Sleevi, 2015/02/27 00:26:39]

We tend to structure it so that callbacks are the last parameter of a method
(since they're akin to output parameters in some ways). It's a pedantic nit, but
could you switch the order of these last two parameters?

[fahl, 2015/02/27 21:16:17]

Done.

 
   // SecurityInterstitialPage method:
   const void* GetTypeForTesting() const override;
@@ -118,6 +119,8 @@ class SSLBlockingPage : public SecurityInterstitialPage {
   const bool expired_but_previously_allowed_;
   scoped_ptr<SSLErrorClassification> ssl_error_classification_;
   scoped_ptr<SecurityInterstitialMetricsHelper> metrics_helper_;
+  // The interstitial is supposed to use this for all time-based calculations

[Ryan Sleevi, 2015/02/27 00:26:39]

As a comment/description, this doesn't really indicate what it contains, or how
to use it properly. 

// The time at which the interstitial was triggered. The interstitial
// calculates all times relative to this.

(Or whtaever it does; I'm just making things up)

[fahl, 2015/02/27 21:16:17]

Done.

+  const base::Time time_triggered_;
 
   // Which type of interstitial this is.
   enum SSLInterstitialReason {