added clock interstitial to chrome://interstitials

chrome/browser/ssl/ssl_blocking_page.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
 #define CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 52 matching lines @@
 
   // Creates an SSL blocking page. If the blocking page isn't shown, the caller
   // is responsible for cleaning up the blocking page, otherwise the
   // interstitial takes ownership when shown. |options_mask| must be a bitwise
   // mask of SSLBlockingPageOptionsMask values.
   SSLBlockingPage(content::WebContents* web_contents,
                   int cert_error,
                   const net::SSLInfo& ssl_info,
                   const GURL& request_url,
                   int options_mask,
-                  const base::Callback<void(bool)>& callback);
+                  const base::Callback<void(bool)>& callback,
+                  const base::Time& time_triggered);

[Ryan Sleevi, 2015/02/27 00:26:39]

We tend to structure it so that callbacks are the last parameter of a method
(since they're akin to output parameters in some ways). It's a pedantic nit, but
could you switch the order of these last two parameters?

[fahl, 2015/02/27 21:16:17]

Done.

 
   // SecurityInterstitialPage method:
   const void* GetTypeForTesting() const override;
 
   // Returns true if |options_mask| refers to an overridable SSL error.
   static bool IsOptionsOverridable(int options_mask);
 
  protected:
   // InterstitialPageDelegate implementation.
   void CommandReceived(const std::string& command) override;
@@ skipping 27 matching lines @@
   //   - This can be set to "false" dynamically to prevent the behaviour.
   const bool overridable_;
   bool danger_overridable_;
   // Has the site requested strict enforcement of certificate errors?
   const bool strict_enforcement_;
   // Did the user previously allow a bad certificate but the decision has now
   // expired?
   const bool expired_but_previously_allowed_;
   scoped_ptr<SSLErrorClassification> ssl_error_classification_;
   scoped_ptr<SecurityInterstitialMetricsHelper> metrics_helper_;
+  // The interstitial is supposed to use this for all time-based calculations

[Ryan Sleevi, 2015/02/27 00:26:39]

As a comment/description, this doesn't really indicate what it contains, or how
to use it properly. 

// The time at which the interstitial was triggered. The interstitial
// calculates all times relative to this.

(Or whtaever it does; I'm just making things up)

[fahl, 2015/02/27 21:16:17]

Done.

+  const base::Time time_triggered_;
 
   // Which type of interstitial this is.
   enum SSLInterstitialReason {
     SSL_REASON_SSL,
     SSL_REASON_BAD_CLOCK
   } interstitial_reason_;
 
   DISALLOW_COPY_AND_ASSIGN(SSLBlockingPage);
 };
 
 #endif  // CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_