added clock interstitial to chrome://interstitials

chrome/browser/ssl/ssl_blocking_page.h

Index: chrome/browser/ssl/ssl_blocking_page.h
diff --git a/chrome/browser/ssl/ssl_blocking_page.h b/chrome/browser/ssl/ssl_blocking_page.h
index dac5ab41a2f8050a7f99685cf017b820cde0716b..65cde38bd3a27b1fa7110cf16bcb853d37b958a8 100644
--- a/chrome/browser/ssl/ssl_blocking_page.h
+++ b/chrome/browser/ssl/ssl_blocking_page.h
@@ -70,7 +70,8 @@ class SSLBlockingPage : public SecurityInterstitialPage {
                   const net::SSLInfo& ssl_info,
                   const GURL& request_url,
                   int options_mask,
-                  const base::Callback<void(bool)>& callback);
+                  const base::Callback<void(bool)>& callback,
+                  const base::Time& base_time);
 
   // SecurityInterstitialPage method:
   const void* GetTypeForTesting() const override;
@@ -118,6 +119,9 @@ class SSLBlockingPage : public SecurityInterstitialPage {
   const bool expired_but_previously_allowed_;
   scoped_ptr<SSLErrorClassification> ssl_error_classification_;
   scoped_ptr<SecurityInterstitialMetricsHelper> metrics_helper_;
+  // The interstitial is supposed to use this time as the basis for all
+  // calculations

[felt, 2015/02/20 16:01:53]

nit: "...use this for all time-based calculations"

[fahl, 2015/02/23 23:47:49]

Acknowledged.

+  const base::Time base_time_;

[felt, 2015/02/20 16:01:53]

nit: "time_shown_" might be more descriptive?

[lgarron, 2015/02/20 22:12:46]

time_shown_ sounds like it's about the UI (instead of the logic) to me. How
about something like time_triggered_?

[fahl, 2015/02/23 23:47:49]

hmm...although this time value is shown, its actual purpose is to be used as the
base for interstitial calculations. what about "time_interstitial_"?

[fahl, 2015/02/23 23:47:49]

Did we agree on a variable name?

 
   // Which type of interstitial this is.
   enum SSLInterstitialReason {