added clock interstitial to chrome://interstitials

chrome/browser/ssl/ssl_blocking_page.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
 #define CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 52 matching lines @@
 
   // Creates an SSL blocking page. If the blocking page isn't shown, the caller
   // is responsible for cleaning up the blocking page, otherwise the
   // interstitial takes ownership when shown. |options_mask| must be a bitwise
   // mask of SSLBlockingPageOptionsMask values.
   SSLBlockingPage(content::WebContents* web_contents,
                   int cert_error,
                   const net::SSLInfo& ssl_info,
                   const GURL& request_url,
                   int options_mask,
-                  const base::Callback<void(bool)>& callback);
+                  const base::Callback<void(bool)>& callback,
+                  const base::Time& base_time);
 
   // SecurityInterstitialPage method:
   const void* GetTypeForTesting() const override;
 
   // Returns true if |options_mask| refers to an overridable SSL error.
   static bool IsOptionsOverridable(int options_mask);
 
  protected:
   // InterstitialPageDelegate implementation.
   void CommandReceived(const std::string& command) override;
@@ skipping 27 matching lines @@
   //   - This can be set to "false" dynamically to prevent the behaviour.
   const bool overridable_;
   bool danger_overridable_;
   // Has the site requested strict enforcement of certificate errors?
   const bool strict_enforcement_;
   // Did the user previously allow a bad certificate but the decision has now
   // expired?
   const bool expired_but_previously_allowed_;
   scoped_ptr<SSLErrorClassification> ssl_error_classification_;
   scoped_ptr<SecurityInterstitialMetricsHelper> metrics_helper_;
+  // The interstitial is supposed to use this time as the basis for all
+  // calculations

[felt, 2015/02/20 16:01:53]

nit: "...use this for all time-based calculations"

[fahl, 2015/02/23 23:47:49]

Acknowledged.

+  const base::Time base_time_;

[felt, 2015/02/20 16:01:53]

nit: "time_shown_" might be more descriptive?

[lgarron, 2015/02/20 22:12:46]

time_shown_ sounds like it's about the UI (instead of the logic) to me. How
about something like time_triggered_?

[fahl, 2015/02/23 23:47:49]

hmm...although this time value is shown, its actual purpose is to be used as the
base for interstitial calculations. what about "time_interstitial_"?

[fahl, 2015/02/23 23:47:49]

Did we agree on a variable name?

 
   // Which type of interstitial this is.
   enum SSLInterstitialReason {
     SSL_REASON_SSL,
     SSL_REASON_BAD_CLOCK
   } interstitial_reason_;
 
   DISALLOW_COPY_AND_ASSIGN(SSLBlockingPage);
 };
 
 #endif  // CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_