Decrease GrInOrderDrawBuffer::Cmd's reliance on GrInOrderDrawBuffer

Decrease GrInOrderDrawBuffer::Cmd's reliance on GrInOrderDrawBuffer

Committed: https://skia.googlesource.com/skia/+/9888b22fc9cd5d3260d2c3639aec20dc79915d37

[robertphillips, 2015-02-23 20:19:28]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@chromium.org

[robertphillips, 2015-02-23 20:19:59]

PTAL - if this isn't objectionable then I will add some more testing for
SkChunkAlloc.

[robertphillips, 2015-02-24 17:28:18]

robertphillips@google.com changed reviewers:
+ reed@google.com

[robertphillips, 2015-02-24 17:28:31]

Adding Mike for SkChunkAlloc changes

[bsalomon, 2015-02-24 17:37:10]

On 2015/02/23 20:19:59, robertphillips wrote:
> PTAL - if this isn't objectionable then I will add some more testing for
> SkChunkAlloc.

The IODB stuff seems OK to me, but I defer to Joshua since it touches
GrBatchTarget.

[joshualitt, 2015-02-24 21:42:40]

joshualitt@google.com changed reviewers:
+ joshualitt@google.com

[joshualitt, 2015-02-24 21:42:42]

https://codereview.chromium.org/940533003/diff/80001/src/gpu/GrInOrderDrawBuf...
File src/gpu/GrInOrderDrawBuffer.cpp (right):

https://codereview.chromium.org/940533003/diff/80001/src/gpu/GrInOrderDrawBuf...
src/gpu/GrInOrderDrawBuffer.cpp:483: }
Is there anyway to abstract this somehow?  On the one hand I don't care because
its NVPR so do whatever, but on the other hand I could see someone puzzling over
this code the first time they see it.

[joshualitt, 2015-02-25 15:39:43]

On 2015/02/24 21:42:42, joshualitt wrote:
>
https://codereview.chromium.org/940533003/diff/80001/src/gpu/GrInOrderDrawBuf...
> File src/gpu/GrInOrderDrawBuffer.cpp (right):
> 
>
https://codereview.chromium.org/940533003/diff/80001/src/gpu/GrInOrderDrawBuf...
> src/gpu/GrInOrderDrawBuffer.cpp:483: }
> Is there anyway to abstract this somehow?  On the one hand I don't care
because
> its NVPR so do whatever, but on the other hand I could see someone puzzling
over
> this code the first time they see it.

after talking with Robert, lgtm

[robertphillips, 2015-02-27 16:41:20]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2015-02-27 16:41:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
joshualitt@google.com
Link to the patchset: https://codereview.chromium.org/940533003/#ps140001
(title: "Update to ToT (again)")

[commit-bot: I haz the power, 2015-02-27 16:41:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/940533003/140001

[commit-bot: I haz the power, 2015-02-27 16:50:39]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/9888b22fc9cd5d3260d2c3639aec20dc79915d37