Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 940523003: Make gl_bindings_skia_in_process work with OpenGL ES3 (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
CC:
chromium-reviews, eseidel, Stephen White, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make gl_bindings_skia_in_process work with OpenGL ES3 When GL_VERSION is set to ES3, Skia assumes that various functions exist in its GL function table. This CL wires up those functions so that Skia can use gl_bindings_skia_in_process on devices that support ES3. One of these functions, glGetStringi, was missing from the autogen script, so I added it. R=kbr@chromium.org Committed: https://crrev.com/35cf7c17a5831ee0b428701b3c9c36a877435a5d Cr-Commit-Position: refs/heads/master@{#316984}

Patch Set 1 #

Patch Set 2 : build fix #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -1 line) Patch
M ui/gl/generate_bindings.py View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_api_autogen_gl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_bindings_autogen_gl.h View 4 chunks +5 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_autogen_gl.cc View 7 chunks +37 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_autogen_mock.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_autogen_mock.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_skia_in_process.cc View 1 8 chunks +36 lines, -1 line 2 comments Download
M ui/gl/gl_mock_autogen_gl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
abarth-chromium
5 years, 10 months ago (2015-02-18 22:28:47 UTC) #1
Ken Russell (switch to Gerrit)
+zmo, senorblanco as FYI LGTM https://codereview.chromium.org/940523003/diff/20001/ui/gl/gl_bindings_skia_in_process.cc File ui/gl/gl_bindings_skia_in_process.cc (right): https://codereview.chromium.org/940523003/diff/20001/ui/gl/gl_bindings_skia_in_process.cc#newcode232 ui/gl/gl_bindings_skia_in_process.cc:232: GLvoid StubGLFlushMappedBufferRange(GLenum target, GLintptr ...
5 years, 10 months ago (2015-02-18 23:05:05 UTC) #2
abarth-chromium
https://codereview.chromium.org/940523003/diff/20001/ui/gl/gl_bindings_skia_in_process.cc File ui/gl/gl_bindings_skia_in_process.cc (right): https://codereview.chromium.org/940523003/diff/20001/ui/gl/gl_bindings_skia_in_process.cc#newcode232 ui/gl/gl_bindings_skia_in_process.cc:232: GLvoid StubGLFlushMappedBufferRange(GLenum target, GLintptr offset, On 2015/02/18 at 23:05:05, ...
5 years, 10 months ago (2015-02-19 00:07:32 UTC) #3
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-19 00:07:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940523003/20001
5 years, 10 months ago (2015-02-19 00:09:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tests_recipe/builds/3211)
5 years, 10 months ago (2015-02-19 01:54:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940523003/20001
5 years, 10 months ago (2015-02-19 02:22:09 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 03:16:38 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 03:17:35 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/35cf7c17a5831ee0b428701b3c9c36a877435a5d
Cr-Commit-Position: refs/heads/master@{#316984}

Powered by Google App Engine
This is Rietveld 408576698