Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 940463006: Rename GrContentKey to GrUniqueKey (Closed)

Created:
5 years, 10 months ago by bsalomon
Modified:
5 years, 10 months ago
Reviewers:
robertphillips
CC:
skia-review_google.com
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : finish #

Patch Set 3 : minor #

Total comments: 10

Patch Set 4 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -268 lines) Patch
M bench/GrResourceCacheBench.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M include/gpu/GrContext.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M include/gpu/GrGpuResource.h View 1 2 3 4 chunks +7 lines, -7 lines 0 comments Download
M include/gpu/GrResourceKey.h View 1 2 3 5 chunks +56 lines, -23 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
M src/gpu/GrGpuResource.cpp View 1 2 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/GrGpuResourceCacheAccess.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrGpuResourcePriv.h View 1 2 3 3 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/GrPath.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPath.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrResourceCache.h View 1 2 9 chunks +33 lines, -35 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 1 11 chunks +28 lines, -28 lines 0 comments Download
M src/gpu/GrStencilAndCoverPathRenderer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 15 chunks +25 lines, -25 lines 0 comments Download
M src/gpu/effects/GrTextureStripAtlas.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 16 chunks +86 lines, -83 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bsalomon
5 years, 10 months ago (2015-02-19 01:32:05 UTC) #2
robertphillips
lgtm + typos https://codereview.chromium.org/940463006/diff/40001/include/gpu/GrGpuResource.h File include/gpu/GrGpuResource.h (right): https://codereview.chromium.org/940463006/diff/40001/include/gpu/GrGpuResource.h#newcode293 include/gpu/GrGpuResource.h:293: GrScratchKey fScratchKey; line up ? https://codereview.chromium.org/940463006/diff/40001/include/gpu/GrResourceKey.h ...
5 years, 10 months ago (2015-02-19 14:52:30 UTC) #3
bsalomon
https://codereview.chromium.org/940463006/diff/40001/include/gpu/GrGpuResource.h File include/gpu/GrGpuResource.h (right): https://codereview.chromium.org/940463006/diff/40001/include/gpu/GrGpuResource.h#newcode293 include/gpu/GrGpuResource.h:293: GrScratchKey fScratchKey; On 2015/02/19 14:52:29, robertphillips wrote: > line ...
5 years, 10 months ago (2015-02-19 15:05:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940463006/50001
5 years, 10 months ago (2015-02-19 15:06:05 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 15:24:25 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:50001) as
https://skia.googlesource.com/skia/+/8718aafec239c93485e45bbe8fed19d9a8def079

Powered by Google App Engine
This is Rietveld 408576698