Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 940423002: Allow inclusion list and exclusion list to be passed to shill (Closed)

Created:
5 years, 10 months ago by kaliamoorthi
Modified:
5 years, 10 months ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow inclusion list and exclusion list to be passed to shill This CL makes inclusion list and exclusion list to be passed to shill during setparameters API call in third party VPN. BUG=459609 TBR=stevenjb@chromium.org Committed: https://crrev.com/363c3a56af6d09ece71a2af923e7420ff57d9190 Cr-Commit-Position: refs/heads/master@{#317324}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chromeos/dbus/shill_third_party_vpn_driver_client.cc View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
kaliamoorthi
PTAL.
5 years, 10 months ago (2015-02-20 14:55:40 UTC) #2
bartfab (slow)
lgtm https://codereview.chromium.org/940423002/diff/1/chromeos/dbus/shill_third_party_vpn_driver_client.cc File chromeos/dbus/shill_third_party_vpn_driver_client.cc (left): https://codereview.chromium.org/940423002/diff/1/chromeos/dbus/shill_third_party_vpn_driver_client.cc#oldcode22 chromeos/dbus/shill_third_party_vpn_driver_client.cc:22: shill::kGatewayParameterThirdPartyVpn, I presume you will remove these obsolete ...
5 years, 10 months ago (2015-02-20 14:57:47 UTC) #3
kaliamoorthi
https://codereview.chromium.org/940423002/diff/1/chromeos/dbus/shill_third_party_vpn_driver_client.cc File chromeos/dbus/shill_third_party_vpn_driver_client.cc (left): https://codereview.chromium.org/940423002/diff/1/chromeos/dbus/shill_third_party_vpn_driver_client.cc#oldcode22 chromeos/dbus/shill_third_party_vpn_driver_client.cc:22: shill::kGatewayParameterThirdPartyVpn, On 2015/02/20 14:57:47, bartfab wrote: > I presume ...
5 years, 10 months ago (2015-02-20 15:02:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940423002/1
5 years, 10 months ago (2015-02-20 15:03:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 15:30:37 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 15:31:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/363c3a56af6d09ece71a2af923e7420ff57d9190
Cr-Commit-Position: refs/heads/master@{#317324}

Powered by Google App Engine
This is Rietveld 408576698