chromeos/dbus/shill_third_party_vpn_driver_client.cc - Issue 940423002: Allow inclusion list and exclusion list to be passed to shill

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/shill_third_party_vpn_driver_client.cc

Issue 940423002: Allow inclusion list and exclusion list to be passed to shill (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromeos/dbus/shill_third_party_vpn_driver_client.cc

diff --git a/chromeos/dbus/shill_third_party_vpn_driver_client.cc b/chromeos/dbus/shill_third_party_vpn_driver_client.cc

index 3237f501a80ffe08a1ad9ecb14931c3d983de128..a1a761c52b8bd528216a07ecb55bc738fce9c1e9 100644

--- a/chromeos/dbus/shill_third_party_vpn_driver_client.cc

+++ b/chromeos/dbus/shill_third_party_vpn_driver_client.cc

@@ -19,8 +19,8 @@ namespace {

const char* kSetParametersKeyList[] = {

shill::kAddressParameterThirdPartyVpn,

shill::kBroadcastAddressParameterThirdPartyVpn,

- shill::kGatewayParameterThirdPartyVpn,

bartfab (slow) 2015/02/20 14:57:47 I presume you will remove these obsolete constants

kaliamoorthi 2015/02/20 15:02:54 Acknowledged.

- shill::kBypassTunnelForIpParameterThirdPartyVpn,

+ shill::kExclusionListParameterThirdPartyVpn,

+ shill::kInclusionListParameterThirdPartyVpn,

shill::kSubnetPrefixParameterThirdPartyVpn,

shill::kMtuParameterThirdPartyVpn,

shill::kDomainSearchParameterThirdPartyVpn,

« no previous file with comments | « no previous file | no next file » | no next file with comments »