Issue 940323003: Revert of Make SkPixelRef::isLocked() debug-only, remove related dead code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 940323003: Revert of Make SkPixelRef::isLocked() debug-only, remove related dead code. (Closed)

Created:
5 years, 10 months ago by reed2

Modified:
5 years, 10 months ago

Reviewers:
mtklein, mtklein_C, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Make SkPixelRef::isLocked() debug-only, remove related dead code. (patchset #1 id:1 of https://codereview.chromium.org/940083002/) Reason for revert: Broke callers in chrome ../../skia/ext/platform_canvas_unittest.cc:421:56: error: no member named 'isLocked' in 'SkPixelRef' EXPECT_TRUE(platform_bitmap->GetBitmap().pixelRef()->isLocked()); Original issue's description: > Make SkPixelRef::isLocked() debug-only, remove related dead code. > > DM's okay locally with no diffs, no failures. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/8e65712486c66108677a9b0a55ad3e7ca94db555 TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/b92b706dfdd68958f0fec76f8f5e0b7590798907

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+89 lines, -20 lines)			Patch
M	include/core/SkPixelRef.h	View	3 chunks	+41 lines, -1 line	0 comments	Download
M	src/core/SkBitmapProcState.cpp	View	3 chunks	+39 lines, -8 lines	0 comments	Download
M	src/core/SkPixelRef.cpp	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/lazy/SkDiscardablePixelRef.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/lazy/SkDiscardablePixelRef.cpp	View	6 chunks	+1 line, -10 lines	0 comments	Download

Total messages: 3 (0 generated)

reed2

Created Revert of Make SkPixelRef::isLocked() debug-only, remove related dead code.

5 years, 10 months ago (2015-02-20 03:58:59 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940323003/1

5 years, 10 months ago (2015-02-20 04:00:26 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-20 04:00:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b92b706dfdd68958f0fec76f8f5e0b7590798907