Initialize metrics service after cast service is initialized.

chromecast/browser/cast_browser_main_parts.cc

Index: chromecast/browser/cast_browser_main_parts.cc
diff --git a/chromecast/browser/cast_browser_main_parts.cc b/chromecast/browser/cast_browser_main_parts.cc
index 100bea2f63cfe28e60602c8dd40958045d8294b2..7c7b6c6e81ebd784f85ddb7759341d6a0c8baaaa 100644
--- a/chromecast/browser/cast_browser_main_parts.cc
+++ b/chromecast/browser/cast_browser_main_parts.cc
@@ -229,15 +229,13 @@ void CastBrowserMainParts::PreMainMessageLoopRun() {
       cast_browser_process_->pref_service(),
       cast_browser_process_->metrics_service_client(),
       url_request_context_factory_->GetSystemGetter()));
+  cast_browser_process_->cast_service()->Initialize();
 
+  // Initializing metrics service and network delegates must happen after cast
+  // service is intialized because CastMetricsServiceClient and
+  // CastNetworkDelegate may use components initialized by cast service.

[lcwu1, 2015/02/19 23:20:29]

nit: remove 'may' because we know for a fact that they do use components
initialized by the cast service. :-)

[gunsch, 2015/02/19 23:21:46]

Doesn't that depend on the particular CastService implementation?

I don't suppose there's another way we can enforce that in
CastMetricsServiceClient...

[byungchul, 2015/02/19 23:29:01]

May be possible if sys info supports Initialized() and
PlatformIsReportingEnabled does DCHECK(). Anyway, that's out of scope of this
CL.

Le-chun, do you agree not to remove "may" because it depends?

   cast_browser_process_->metrics_service_client()
       ->Initialize(cast_browser_process_->cast_service());
-
-  cast_browser_process_->cast_service()->Initialize();
-
-  // Initializing network delegates must happen after cast service is
-  // initialized because CastNetworkDelegate may use components initialized by
-  // cast service.
   url_request_context_factory_->InitializeNetworkDelegates();
 }