Initialize metrics service after cast service is initialized.

chromecast/browser/cast_browser_main_parts.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/cast_browser_main_parts.h"
 
 #include <signal.h>
 #include <sys/prctl.h>
 
 #include "base/command_line.h"
@@ skipping 211 matching lines @@
     LOG(ERROR) << "PlatformClientAuth::Initialize failed.";
 
   cast_browser_process_->SetRemoteDebuggingServer(
       make_scoped_ptr(new RemoteDebuggingServer()));
 
   cast_browser_process_->SetCastService(CastService::Create(
       cast_browser_process_->browser_context(),
       cast_browser_process_->pref_service(),
       cast_browser_process_->metrics_service_client(),
       url_request_context_factory_->GetSystemGetter()));
+  cast_browser_process_->cast_service()->Initialize();
 
+  // Initializing metrics service and network delegates must happen after cast
+  // service is intialized because CastMetricsServiceClient and
+  // CastNetworkDelegate may use components initialized by cast service.

[lcwu1, 2015/02/19 23:20:29]

nit: remove 'may' because we know for a fact that they do use components
initialized by the cast service. :-)

[gunsch, 2015/02/19 23:21:46]

Doesn't that depend on the particular CastService implementation?

I don't suppose there's another way we can enforce that in
CastMetricsServiceClient...

[byungchul, 2015/02/19 23:29:01]

May be possible if sys info supports Initialized() and
PlatformIsReportingEnabled does DCHECK(). Anyway, that's out of scope of this
CL.

Le-chun, do you agree not to remove "may" because it depends?

   cast_browser_process_->metrics_service_client()
       ->Initialize(cast_browser_process_->cast_service());
-
-  cast_browser_process_->cast_service()->Initialize();
-
-  // Initializing network delegates must happen after cast service is
-  // initialized because CastNetworkDelegate may use components initialized by
-  // cast service.
   url_request_context_factory_->InitializeNetworkDelegates();
 }
 
 bool CastBrowserMainParts::MainMessageLoopRun(int* result_code) {
   cast_browser_process_->cast_service()->Start();
 
   base::RunLoop run_loop;
   base::Closure quit_closure(run_loop.QuitClosure());
   RegisterClosureOnSignal(quit_closure);
 
@@ skipping 11 matching lines @@
 }
 
 void CastBrowserMainParts::PostMainMessageLoopRun() {
   cast_browser_process_->cast_service()->Finalize();
   cast_browser_process_->metrics_service_client()->Finalize();
   cast_browser_process_.reset();
 }
 
 }  // namespace shell
 }  // namespace chromecast