Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 940153002: Telemetry: Add a unit test for InspectorBackendList.GetTabById(). (Closed)

Created:
5 years, 10 months ago by erikchen
Modified:
5 years, 10 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Add a functional test for InspectorBackendList.GetTabById(). This CL also exposes the property tabs on the class TabTestCase. BUG=442546 Committed: https://crrev.com/9f7bd97f10d68f3ef08116a3edf7549606959cf1 Cr-Commit-Position: refs/heads/master@{#317662}

Patch Set 1 #

Patch Set 2 : Add comments. #

Total comments: 1

Patch Set 3 : Comments from nednguyen. #

Total comments: 2

Patch Set 4 : Split into two unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
A tools/telemetry/telemetry/core/backends/chrome/tab_list_backend_unittest.py View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/tab_test_case.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
erikchen
nednguyen: Please review.
5 years, 10 months ago (2015-02-19 21:44:27 UTC) #2
nednguyen
https://codereview.chromium.org/940153002/diff/20001/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list_unittest.py File tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list_unittest.py (right): https://codereview.chromium.org/940153002/diff/20001/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list_unittest.py#newcode15 tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list_unittest.py:15: class InspectorBackendListTest(unittest.TestCase): Can you make a unittest from tab_test_case ...
5 years, 10 months ago (2015-02-19 22:09:42 UTC) #3
erikchen
nednguyen: PTAL
5 years, 10 months ago (2015-02-20 00:50:59 UTC) #5
nednguyen
lgtm https://codereview.chromium.org/940153002/diff/60001/tools/telemetry/telemetry/core/backends/chrome/tab_list_backend_unittest.py File tools/telemetry/telemetry/core/backends/chrome/tab_list_backend_unittest.py (right): https://codereview.chromium.org/940153002/diff/60001/tools/telemetry/telemetry/core/backends/chrome/tab_list_backend_unittest.py#newcode21 tools/telemetry/telemetry/core/backends/chrome/tab_list_backend_unittest.py:21: # Crash the first tab. Nit: Can you ...
5 years, 10 months ago (2015-02-20 01:44:32 UTC) #6
erikchen
https://codereview.chromium.org/940153002/diff/60001/tools/telemetry/telemetry/core/backends/chrome/tab_list_backend_unittest.py File tools/telemetry/telemetry/core/backends/chrome/tab_list_backend_unittest.py (right): https://codereview.chromium.org/940153002/diff/60001/tools/telemetry/telemetry/core/backends/chrome/tab_list_backend_unittest.py#newcode21 tools/telemetry/telemetry/core/backends/chrome/tab_list_backend_unittest.py:21: # Crash the first tab. On 2015/02/20 01:44:31, nednguyen ...
5 years, 10 months ago (2015-02-23 18:38:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940153002/80001
5 years, 10 months ago (2015-02-23 18:38:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61788)
5 years, 10 months ago (2015-02-23 18:41:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940153002/80001
5 years, 10 months ago (2015-02-23 18:47:44 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61801)
5 years, 10 months ago (2015-02-23 18:51:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940153002/80001
5 years, 10 months ago (2015-02-23 21:38:33 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 10 months ago (2015-02-23 22:11:04 UTC) #19
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 22:11:41 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9f7bd97f10d68f3ef08116a3edf7549606959cf1
Cr-Commit-Position: refs/heads/master@{#317662}

Powered by Google App Engine
This is Rietveld 408576698