Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/tab_list_backend_unittest.py

Issue 940153002: Telemetry: Add a unit test for InspectorBackendList.GetTabById(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split into two unittests. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/unittest_util/tab_test_case.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/backends/chrome/tab_list_backend_unittest.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/tab_list_backend_unittest.py b/tools/telemetry/telemetry/core/backends/chrome/tab_list_backend_unittest.py
new file mode 100644
index 0000000000000000000000000000000000000000..c4377dbfa9aca5ebf9401769d63bd5a9b4509202
--- /dev/null
+++ b/tools/telemetry/telemetry/core/backends/chrome/tab_list_backend_unittest.py
@@ -0,0 +1,37 @@
+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+from telemetry.core import exceptions
+from telemetry.unittest_util import tab_test_case
+
+
+class TabListBackendTest(tab_test_case.TabTestCase):
+ def testTabIdMatchesContextId(self):
+ # Ensure that there are two tabs.
+ while len(self.tabs) < 2:
+ self.tabs.New()
+
+ # Check that the tab.id matches context_id.
+ tabs = []
+ for context_id in self.tabs:
+ tab = self.tabs.GetTabById(context_id)
+ self.assertEquals(tab.id, context_id)
+ tabs.append(self.tabs.GetTabById(context_id))
+
+ def testTabIdStableAfterTabCrash(self):
+ # Ensure that there are two tabs.
+ while len(self.tabs) < 2:
+ self.tabs.New()
+
+ tabs = []
+ for context_id in self.tabs:
+ tabs.append(self.tabs.GetTabById(context_id))
+
+ # Crash the first tab.
+ self.assertRaises(exceptions.DevtoolsTargetCrashException,
+ lambda: tabs[0].Navigate('chrome://crash'))
+
+ # Fetching the second tab by id should still work. Fetching the first tab
+ # should raise an exception.
+ self.assertEquals(tabs[1], self.tabs.GetTabById(tabs[1].id))
+ self.assertRaises(KeyError, lambda: self.tabs.GetTabById(tabs[0].id))
« no previous file with comments | « no previous file | tools/telemetry/telemetry/unittest_util/tab_test_case.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698