Add ignore-unrecognized-flags as an option to the command line options of analysis server

pkg/analysis_server/lib/src/server/driver.dart

Index: pkg/analysis_server/lib/src/server/driver.dart
diff --git a/pkg/analysis_server/lib/src/server/driver.dart b/pkg/analysis_server/lib/src/server/driver.dart
index 504589c8e1ee7d079488909bf5bfe3cc1c801e47..674f8387f834a599db723b0abbb0ff86121b0574 100644
--- a/pkg/analysis_server/lib/src/server/driver.dart
+++ b/pkg/analysis_server/lib/src/server/driver.dart
@@ -23,6 +23,7 @@ import 'package:analyzer/src/generated/incremental_logger.dart';
 import 'package:analyzer/src/generated/java_io.dart';
 import 'package:analyzer/src/generated/sdk.dart';
 import 'package:analyzer/src/generated/sdk_io.dart';
+import 'package:analyzer/options.dart';
 import 'package:args/args.dart';
 
 /**
@@ -170,10 +171,10 @@ class Driver implements ServerStarter {
    * Use the given command-line [arguments] to start this server.
    */
   void start(List<String> arguments) {
-    ArgParser parser = _createArgParser();
-    ArgResults results = parser.parse(arguments);
+    CommandLineParser parser = _createArgParser();
+    ArgResults results = parser.parse(arguments, <String, String>{});
     if (results[HELP_OPTION]) {
-      _printUsage(parser);
+      _printUsage(parser.parser);
       return;
     }
 
@@ -211,7 +212,7 @@ class Driver implements ServerStarter {
       } on FormatException {
         print('Invalid port number: ${results[PORT_OPTION]}');
         print('');
-        _printUsage(parser);
+        _printUsage(parser.parser);
         exitCode = 1;
         return;
       }
@@ -309,13 +310,18 @@ class Driver implements ServerStarter {
   /**
    * Create and return the parser used to parse the command-line arguments.
    */
-  ArgParser _createArgParser() {
-    ArgParser parser = new ArgParser();
+  CommandLineParser _createArgParser() {
+    CommandLineParser parser = new CommandLineParser();
     parser.addOption(
         CLIENT_ID,
         help: "an identifier used to identify the client");
     parser.addOption(CLIENT_VERSION, help: "the version of the client");
     parser.addFlag(
+        'ignore-unrecognized-flags',

[Brian Wilkerson, 2015/02/19 20:44:09]

I thought we were making this the default behavior (that is, that we wouldn't
need a flag).

[Paul Berry, 2015/02/19 21:10:16]

My recollection matches Brian's.  IIRC, we argued that if we make it an explicit
flag, there is too much danger of a client forgetting to supply it, resulting in
backward compatibility problems.

+        help: 'Ignore unrecognized command line flags',
+        defaultsTo: false,
+        negatable: false);
+    parser.addFlag(
         ENABLE_INCREMENTAL_RESOLUTION_API,
         help: "enable using incremental resolution for API changes",
         defaultsTo: false,