Add ignore-unrecognized-flags as an option to the command line options of analysis server

pkg/analysis_server/lib/src/server/driver.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library driver;
 
 import 'dart:async';
 import 'dart:io';
 import 'dart:math';
 
 import 'package:analysis_server/plugin/plugin.dart';
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/plugin/plugin_impl.dart';
 import 'package:analysis_server/src/plugin/server_plugin.dart';
 import 'package:analysis_server/src/server/http_server.dart';
 import 'package:analysis_server/src/server/stdio_server.dart';
 import 'package:analysis_server/src/socket_server.dart';
 import 'package:analysis_server/starter.dart';
 import 'package:analyzer/file_system/physical_file_system.dart';
 import 'package:analyzer/instrumentation/instrumentation.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/incremental_logger.dart';
 import 'package:analyzer/src/generated/java_io.dart';
 import 'package:analyzer/src/generated/sdk.dart';
 import 'package:analyzer/src/generated/sdk_io.dart';
+import 'package:analyzer/options.dart';
 import 'package:args/args.dart';
 
 /**
  * Initializes incremental logger.
  *
  * Supports following formats of [spec]:
  *
  *     "console" - log to the console;
  *     "file:/some/file/name" - log to the file, overwritten on start.
  */
@@ skipping 127 matching lines @@
    * Set the [plugins] that are defined outside the analysis_server package.
    */
   void set userDefinedPlugins(List<Plugin> plugins) {
     _userDefinedPlugins = plugins == null ? <Plugin>[] : plugins;
   }
 
   /**
    * Use the given command-line [arguments] to start this server.
    */
   void start(List<String> arguments) {
-    ArgParser parser = _createArgParser();
-    ArgResults results = parser.parse(arguments);
+    CommandLineParser parser = _createArgParser();
+    ArgResults results = parser.parse(arguments, <String, String>{});
     if (results[HELP_OPTION]) {
-      _printUsage(parser);
+      _printUsage(parser.parser);
       return;
     }
 
     // TODO(brianwilkerson) Enable this after it is possible for an
     // instrumentation server to be provided.
 //    if (results[ENABLE_INSTRUMENTATION_OPTION]) {
 //      if (instrumentationServer == null) {
 //        print('Exiting server: enabled instrumentation without providing an instrumentation server');
 //        print('');
 //        _printUsage(parser);
@@ skipping 17 matching lines @@
 
     int port;
     bool serve_http = false;
     if (results[PORT_OPTION] != null) {
       serve_http = true;
       try {
         port = int.parse(results[PORT_OPTION]);
       } on FormatException {
         print('Invalid port number: ${results[PORT_OPTION]}');
         print('');
-        _printUsage(parser);
+        _printUsage(parser.parser);
         exitCode = 1;
         return;
       }
     }
 
     AnalysisServerOptions analysisServerOptions = new AnalysisServerOptions();
     analysisServerOptions.enableIncrementalResolutionApi =
         results[ENABLE_INCREMENTAL_RESOLUTION_API];
     analysisServerOptions.enableIncrementalResolutionValidation =
         results[INCREMENTAL_RESOLUTION_VALIDATION];
@@ skipping 77 matching lines @@
     };
     ZoneSpecification zoneSpecification = new ZoneSpecification(
         handleUncaughtError: errorFunction,
         print: printFunction);
     return runZoned(callback, zoneSpecification: zoneSpecification);
   }
 
   /**
    * Create and return the parser used to parse the command-line arguments.
    */
-  ArgParser _createArgParser() {
-    ArgParser parser = new ArgParser();
+  CommandLineParser _createArgParser() {
+    CommandLineParser parser = new CommandLineParser();
     parser.addOption(
         CLIENT_ID,
         help: "an identifier used to identify the client");
     parser.addOption(CLIENT_VERSION, help: "the version of the client");
     parser.addFlag(
+        'ignore-unrecognized-flags',

[Brian Wilkerson, 2015/02/19 20:44:09]

I thought we were making this the default behavior (that is, that we wouldn't
need a flag).

[Paul Berry, 2015/02/19 21:10:16]

My recollection matches Brian's.  IIRC, we argued that if we make it an explicit
flag, there is too much danger of a client forgetting to supply it, resulting in
backward compatibility problems.

+        help: 'Ignore unrecognized command line flags',
+        defaultsTo: false,
+        negatable: false);
+    parser.addFlag(
         ENABLE_INCREMENTAL_RESOLUTION_API,
         help: "enable using incremental resolution for API changes",
         defaultsTo: false,
         negatable: false);
     parser.addFlag(
         ENABLE_INSTRUMENTATION_OPTION,
         help: "enable sending instrumentation information to a server",
         defaultsTo: false,
         negatable: false);
     parser.addFlag(
@@ skipping 78 matching lines @@
       uuidFile.parent.createSync(recursive: true);
       uuidFile.writeAsStringSync(uuid);
     } catch (exception, stackTrace) {
       service.logPriorityException(exception, stackTrace);
       // Slightly alter the uuid to indicate it was not persisted
       uuid = 'temp-$uuid';
     }
     return uuid;
   }
 }