Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: pkg/compiler/lib/src/js_emitter/model.dart

Issue 940053002: dart2js: add function type to the model. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/model.dart
diff --git a/pkg/compiler/lib/src/js_emitter/model.dart b/pkg/compiler/lib/src/js_emitter/model.dart
index f2a5cc9b0de09a4c349fbb9bb91a8154fef662a5..24e8cf037b40985a8ab1251fb71fe159773a6dec 100644
--- a/pkg/compiler/lib/src/js_emitter/model.dart
+++ b/pkg/compiler/lib/src/js_emitter/model.dart
@@ -348,6 +348,7 @@ class DartMethod extends Method {
final bool canBeApplied;
final bool canBeReflected;
final DartType type;
+ final js.Expression functionType;
floitsch 2015/02/20 11:00:11 Add comment. (when is it null? can it be null?) W
zarah 2015/02/20 12:59:32 As far as I can see, we don't use the "type" anymo
// Signature information for this method. This is only required and stored
// here if the method [canBeApplied] or [canBeReflected]
@@ -363,7 +364,7 @@ class DartMethod extends Method {
this.parameterStubs, this.callName, this.type,
{this.needsTearOff, this.tearOffName, this.canBeApplied,
this.canBeReflected, this.requiredParameterCount,
- this.optionalParameterDefaultValues})
+ this.optionalParameterDefaultValues, this.functionType})
: super(element, name, code) {
assert(needsTearOff != null);
assert(!needsTearOff || tearOffName != null);
@@ -394,14 +395,16 @@ class InstanceMethod extends DartMethod {
bool canBeReflected,
int requiredParameterCount,
/* List | Map */ optionalParameterDefaultValues,
- this.isClosure})
+ this.isClosure,
+ js.Expression functionType})
: super(element, name, code, parameterStubs, callName, type,
needsTearOff: needsTearOff,
tearOffName: tearOffName,
canBeApplied: canBeApplied,
canBeReflected: canBeReflected,
requiredParameterCount: requiredParameterCount,
- optionalParameterDefaultValues: optionalParameterDefaultValues) {
+ optionalParameterDefaultValues: optionalParameterDefaultValues,
+ functionType: functionType) {
assert(isClosure != null);
}
}
@@ -448,14 +451,16 @@ class StaticDartMethod extends DartMethod implements StaticMethod {
String callName, DartType type,
{bool needsTearOff, String tearOffName, bool canBeApplied,
bool canBeReflected, int requiredParameterCount,
- /* List | Map */ optionalParameterDefaultValues})
+ /* List | Map */ optionalParameterDefaultValues,
+ js.Expression functionType})
: super(element, name, code, parameterStubs, callName, type,
needsTearOff: needsTearOff,
tearOffName : tearOffName,
canBeApplied : canBeApplied,
canBeReflected : canBeReflected,
requiredParameterCount: requiredParameterCount,
- optionalParameterDefaultValues: optionalParameterDefaultValues);
+ optionalParameterDefaultValues: optionalParameterDefaultValues,
+ functionType: functionType);
}
class StaticStubMethod extends StubMethod implements StaticMethod {

Powered by Google App Engine
This is Rietveld 408576698