dart2js: add function type to the model.

pkg/compiler/lib/src/js_emitter/model.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.new_js_emitter.model;
 
 import '../js/js.dart' as js show Expression, Statement;
 import '../constants/values.dart' show ConstantValue;
 
 import '../deferred_load.dart' show OutputUnit;
@@ skipping 330 matching lines @@
 }
 
 /// A method that corresponds to a method in the original Dart program.
 class DartMethod extends Method {
   final bool needsTearOff;
   final String tearOffName;
   final List<ParameterStubMethod> parameterStubs;
   final bool canBeApplied;
   final bool canBeReflected;
   final DartType type;
+  final js.Expression functionType;

[floitsch, 2015/02/20 11:00:11]

Add comment. (when is it null? can it be null?)

While you are at it: the "type" needs documentation too.

What's the difference between the two?

[zarah, 2015/02/20 12:59:32]

As far as I can see, we don't use the "type" anymore, so I will remove it.

Added comment.

 
   // Signature information for this method. This is only required and stored
   // here if the method [canBeApplied] or [canBeReflected]
   final int requiredParameterCount;
   final /* Map | List */ optionalParameterDefaultValues;
 
   // If this method can be torn off, contains the name of the corresponding
   // call method. For example, for the member `foo$1$name` it would be
   // `call$1$name` (in unminified mode).
   final String callName;
 
   DartMethod(Element element, String name, js.Expression code,
              this.parameterStubs, this.callName, this.type,
              {this.needsTearOff, this.tearOffName, this.canBeApplied,
               this.canBeReflected, this.requiredParameterCount,
-              this.optionalParameterDefaultValues})
+              this.optionalParameterDefaultValues, this.functionType})
       : super(element, name, code) {
     assert(needsTearOff != null);
     assert(!needsTearOff || tearOffName != null);
     assert(canBeApplied != null);
     assert(canBeReflected != null);
     assert((!canBeReflected && !canBeApplied) ||
            (requiredParameterCount != null &&
             optionalParameterDefaultValues != null));
   }
 }
@@ skipping 10 matching lines @@
   InstanceMethod(Element element, String name, js.Expression code,
                  List<ParameterStubMethod> parameterStubs,
                  String callName, DartType type,
                  {bool needsTearOff,
                   String tearOffName,
                   this.aliasName,
                   bool canBeApplied,
                   bool canBeReflected,
                   int requiredParameterCount,
                   /* List | Map */ optionalParameterDefaultValues,
-                  this.isClosure})
+                  this.isClosure,
+                  js.Expression functionType})
       : super(element, name, code, parameterStubs, callName, type,
               needsTearOff: needsTearOff,
               tearOffName: tearOffName,
               canBeApplied: canBeApplied,
               canBeReflected: canBeReflected,
               requiredParameterCount: requiredParameterCount,
-              optionalParameterDefaultValues: optionalParameterDefaultValues) {
+              optionalParameterDefaultValues: optionalParameterDefaultValues,
+              functionType: functionType) {
     assert(isClosure != null);
   }
 }
 
 /// A method that is generated by the backend and has not direct correspondence
 /// to a method in the original Dart program. Examples are getter and setter
 /// stubs and stubs to dispatch calls to methods with optional parameters.
 class StubMethod extends Method {
   StubMethod(String name, js.Expression code,
              {Element element})
@@ skipping 26 matching lines @@
 }
 
 class StaticDartMethod extends DartMethod implements StaticMethod {
   final Holder holder;
 
   StaticDartMethod(Element element, String name, this.holder,
                    js.Expression code, List<ParameterStubMethod> parameterStubs,
                    String callName, DartType type,
                    {bool needsTearOff, String tearOffName, bool canBeApplied,
                     bool canBeReflected, int requiredParameterCount,
-                    /* List | Map */ optionalParameterDefaultValues})
+                    /* List | Map */ optionalParameterDefaultValues,
+                    js.Expression functionType})
       : super(element, name, code, parameterStubs, callName, type,
               needsTearOff: needsTearOff,
               tearOffName : tearOffName,
               canBeApplied : canBeApplied,
               canBeReflected : canBeReflected,
               requiredParameterCount: requiredParameterCount,
-              optionalParameterDefaultValues: optionalParameterDefaultValues);
+              optionalParameterDefaultValues: optionalParameterDefaultValues,
+              functionType: functionType);
 }
 
 class StaticStubMethod extends StubMethod implements StaticMethod {
   Holder holder;
   StaticStubMethod(String name, this.holder, js.Expression code)
       : super(name, code);
 }