Issue 939483005: Merge RenderLayer::hitTest into RenderView::hitTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 939483005: Merge RenderLayer::hitTest into RenderView::hitTest. (Closed)

Created:
5 years, 10 months ago by ojan

Modified:
5 years, 10 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Merge RenderLayer::hitTest into RenderView::hitTest. Only RenderView calls this method. The actual tree walk happens in RenderLayer::hitTestLayer, which a followup patch will move into RenderBox. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ec51f6c6d623020a1ea9c810d087cfde71d6e5c5

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -43 lines)			Patch
M	sky/engine/core/rendering/RenderLayer.h	View		3 chunks	+4 lines, -7 lines	0 comments	Download
M	sky/engine/core/rendering/RenderLayer.cpp	View		1 chunk	+0 lines, -34 lines	0 comments	Download
M	sky/engine/core/rendering/RenderView.cpp	View	1	1 chunk	+23 lines, -1 line	0 comments	Download
M	sky/engine/web/WebLocalFrameImpl.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (1 generated)

ojan

5 years, 10 months ago (2015-02-19 03:29:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ec51f6c6d623020a1ea9c810d087cfde71d6e5c5 (presubmit successful).