Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 939353002: Fix mojo::shell::Context shutdown. (Closed)

Created:
5 years, 10 months ago by viettrungluu
Modified:
5 years, 10 months ago
Reviewers:
jamesr, qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix mojo::shell::Context shutdown. Make shutdown explicit (i.e., if you call Init(), you have to call Shutdown()). R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0ba64d60772d782fcbb1e0becc7aebfba1d82866

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -8 lines) Patch
M shell/child_process_host_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M shell/context.h View 3 chunks +8 lines, -3 lines 0 comments Download
M shell/context.cc View 4 chunks +12 lines, -4 lines 0 comments Download
M shell/desktop/mojo_main.cc View 1 chunk +3 lines, -0 lines 2 comments Download
M shell/in_process_dynamic_service_runner_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M shell/native_application_loader_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M shell/shell_test_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M shell/shell_test_base.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
5 years, 10 months ago (2015-02-19 22:38:47 UTC) #1
jamesr
@#$*(ing shutdown wait, not that kind of explicit? lgtm
5 years, 10 months ago (2015-02-19 22:47:16 UTC) #2
viettrungluu
Committed patchset #1 (id:1) manually as 0ba64d60772d782fcbb1e0becc7aebfba1d82866 (presubmit successful).
5 years, 10 months ago (2015-02-19 22:50:24 UTC) #3
qsr
https://codereview.chromium.org/939353002/diff/1/shell/desktop/mojo_main.cc File shell/desktop/mojo_main.cc (right): https://codereview.chromium.org/939353002/diff/1/shell/desktop/mojo_main.cc#newcode112 shell/desktop/mojo_main.cc:112: // Must be called be |message_loop| is destroyed. nit: ...
5 years, 10 months ago (2015-02-20 13:14:31 UTC) #5
viettrungluu
5 years, 10 months ago (2015-02-20 15:59:34 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/939353002/diff/1/shell/desktop/mojo_main.cc
File shell/desktop/mojo_main.cc (right):

https://codereview.chromium.org/939353002/diff/1/shell/desktop/mojo_main.cc#n...
shell/desktop/mojo_main.cc:112: // Must be called be |message_loop| is
destroyed.
On 2015/02/20 13:14:31, qsr wrote:
> nit: Comment seems wrong.

Oops. I TBRed a fix for this. Thanks.

Powered by Google App Engine
This is Rietveld 408576698