Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: shell/desktop/mojo_main.cc

Issue 939353002: Fix mojo::shell::Context shutdown. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/context.cc ('k') | shell/in_process_dynamic_service_runner_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/desktop/mojo_main.cc
diff --git a/shell/desktop/mojo_main.cc b/shell/desktop/mojo_main.cc
index 8989b9ee9b526c5fa789b0dfe94a3a570ef94473..d8ac65765c65db11191bba7717956c11bafb5234 100644
--- a/shell/desktop/mojo_main.cc
+++ b/shell/desktop/mojo_main.cc
@@ -108,6 +108,9 @@ int main(int argc, char** argv) {
FROM_HERE,
base::Bind(&mojo::shell::RunCommandLineApps, &shell_context));
message_loop.Run();
+
+ // Must be called be |message_loop| is destroyed.
qsr 2015/02/20 13:14:31 nit: Comment seems wrong.
viettrungluu 2015/02/20 15:59:33 Oops. I TBRed a fix for this. Thanks.
+ shell_context.Shutdown();
}
}
return 0;
« no previous file with comments | « shell/context.cc ('k') | shell/in_process_dynamic_service_runner_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698