Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 939343003: content: Add valid handle check to ChildDiscardableSharedMemoryManager::AllocateLockedDiscardableSh… (Closed)

Created:
5 years, 10 months ago by reveman
Modified:
5 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Add valid handle check to ChildDiscardableSharedMemoryManager::AllocateLockedDiscardableSharedMemory. This check allows us to distinguish between allocation failure on the browser side and failure to map the memory in the child process. BUG=460995 Committed: https://crrev.com/527e2da9822a168f55dcf23fb51a28202f90879a Cr-Commit-Position: refs/heads/master@{#317746}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/child/child_discardable_shared_memory_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reveman
5 years, 10 months ago (2015-02-23 19:43:31 UTC) #2
Avi (use Gerrit)
lgtm ok
5 years, 10 months ago (2015-02-23 19:47:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939343003/1
5 years, 10 months ago (2015-02-24 02:22:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 02:43:48 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 02:44:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/527e2da9822a168f55dcf23fb51a28202f90879a
Cr-Commit-Position: refs/heads/master@{#317746}

Powered by Google App Engine
This is Rietveld 408576698