content/child/child_discardable_shared_memory_manager.cc - Issue 939343003: content: Add valid handle check to ChildDiscardableSharedMemoryManager::AllocateLockedDiscardableSh…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/child_discardable_shared_memory_manager.cc

Issue 939343003: content: Add valid handle check to ChildDiscardableSharedMemoryManager::AllocateLockedDiscardableSh… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/child/child_discardable_shared_memory_manager.cc

diff --git a/content/child/child_discardable_shared_memory_manager.cc b/content/child/child_discardable_shared_memory_manager.cc

index 140e9495d58f7a7665b7b686c2c65db02c0bcc95..b1a6b8098267b189dd218c6e196a80fea27c810b 100644

--- a/content/child/child_discardable_shared_memory_manager.cc

+++ b/content/child/child_discardable_shared_memory_manager.cc

@@ -187,6 +187,7 @@ ChildDiscardableSharedMemoryManager::AllocateLockedDiscardableSharedMemory(

sender_->Send(

new ChildProcessHostMsg_SyncAllocateLockedDiscardableSharedMemory(

size, &handle));

+ CHECK(base::SharedMemory::IsHandleValid(handle));

scoped_ptr<base::DiscardableSharedMemory> memory(

new base::DiscardableSharedMemory(handle));

CHECK(memory->Map(size));

« no previous file with comments | « no previous file | no next file » | no next file with comments »