V8 and Skia

V8 and Skia

Committed: http://code.google.com/p/skia/source/detail?r=12503

[robertphillips, 2013-12-03 19:52:25]

Can we rename it to SkV8Example.* and land it (without the gyp file changes)?

[jcgregorio, 2013-12-03 20:26:56]

https://codereview.chromium.org/93933005/diff/40001/gyp/everything.gyp
File gyp/everything.gyp (right):

https://codereview.chromium.org/93933005/diff/40001/gyp/everything.gyp#newcode25
gyp/everything.gyp:25: 'v8.gyp:SkV8Example',
Should I land it with this line commented out, or just drop all the gyp files
from the CL for now?

[robertphillips, 2013-12-03 20:49:27]

lgtm

https://codereview.chromium.org/93933005/diff/40001/experimental/SkV8Example/...
File experimental/SkV8Example/SkV8Example.h (right):

https://codereview.chromium.org/93933005/diff/40001/experimental/SkV8Example/...
experimental/SkV8Example/SkV8Example.h:14: 
I think we only need SkCanvas here.

https://codereview.chromium.org/93933005/diff/40001/experimental/SkV8Example/...
experimental/SkV8Example/SkV8Example.h:23: public:
Don't think we need DeviceType.

https://codereview.chromium.org/93933005/diff/40001/gyp/everything.gyp
File gyp/everything.gyp (right):

https://codereview.chromium.org/93933005/diff/40001/gyp/everything.gyp#newcode25
gyp/everything.gyp:25: 'v8.gyp:SkV8Example',
I say commented out. I'm never going to remember that syntax.

https://codereview.chromium.org/93933005/diff/40001/gyp/v8.gyp
File gyp/v8.gyp (right):

https://codereview.chromium.org/93933005/diff/40001/gyp/v8.gyp#newcode1
gyp/v8.gyp:1: # GYP file to build experimental directory.
Update the description?

https://codereview.chromium.org/93933005/diff/40001/gyp/v8.gyp#newcode70
gyp/v8.gyp:70: 'xcode_settings' : {
Doesn't this have to change?

https://codereview.chromium.org/93933005/diff/40001/gyp/v8.gyp#newcode73
gyp/v8.gyp:73: 'mac_bundle_resources' : [
This too?

[jcgregorio, 2013-12-03 21:06:43]

https://codereview.chromium.org/93933005/diff/40001/experimental/SkV8Example/...
File experimental/SkV8Example/SkV8Example.h (right):

https://codereview.chromium.org/93933005/diff/40001/experimental/SkV8Example/...
experimental/SkV8Example/SkV8Example.h:14: 
On 2013/12/03 20:49:27, robertphillips wrote:
> I think we only need SkCanvas here.

Done.

https://codereview.chromium.org/93933005/diff/40001/experimental/SkV8Example/...
experimental/SkV8Example/SkV8Example.h:23: public:
On 2013/12/03 20:49:27, robertphillips wrote:
> Don't think we need DeviceType.

Done.

https://codereview.chromium.org/93933005/diff/40001/gyp/everything.gyp
File gyp/everything.gyp (right):

https://codereview.chromium.org/93933005/diff/40001/gyp/everything.gyp#newcode25
gyp/everything.gyp:25: 'v8.gyp:SkV8Example',
On 2013/12/03 20:49:27, robertphillips wrote:
> I say commented out. I'm never going to remember that syntax.

Done.

https://codereview.chromium.org/93933005/diff/40001/gyp/v8.gyp
File gyp/v8.gyp (right):

https://codereview.chromium.org/93933005/diff/40001/gyp/v8.gyp#newcode1
gyp/v8.gyp:1: # GYP file to build experimental directory.
On 2013/12/03 20:49:27, robertphillips wrote:
> Update the description?

Done.

https://codereview.chromium.org/93933005/diff/40001/gyp/v8.gyp#newcode70
gyp/v8.gyp:70: 'xcode_settings' : {
On 2013/12/03 20:49:27, robertphillips wrote:
> Doesn't this have to change?


I have no idea, can I just copy the files over from SkiaExamples? Maybe I just
delete them until someone needs them?

[robertphillips, 2013-12-04 18:40:58]

Ship it.

https://codereview.chromium.org/93933005/diff/40001/gyp/v8.gyp
File gyp/v8.gyp (right):

https://codereview.chromium.org/93933005/diff/40001/gyp/v8.gyp#newcode70
gyp/v8.gyp:70: 'xcode_settings' : {
Let's leave dealing with this stuff until later.

[commit-bot: I haz the power, 2013-12-05 13:33:27]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/93933005/80001

[commit-bot: I haz the power, 2013-12-05 13:45:22]

Change committed as 12503