Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: Source/core/html/track/vtt/VTTCue.cpp

Issue 939193002: Remove TextTrackCue::notifyRegionWhenRemovingDisplayTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Hoist removeDisplayTree-call from setIsActive. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/track/vtt/VTTCue.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/vtt/VTTCue.cpp
diff --git a/Source/core/html/track/vtt/VTTCue.cpp b/Source/core/html/track/vtt/VTTCue.cpp
index 4bac32a98409deb9d3abe976449d98c582ec4305..46cca1aca7873a599541f9e86832934b0d8f8177 100644
--- a/Source/core/html/track/vtt/VTTCue.cpp
+++ b/Source/core/html/track/vtt/VTTCue.cpp
@@ -229,7 +229,6 @@ VTTCue::VTTCue(Document& document, double startTime, double endTime, const Strin
, m_cueBackgroundBox(HTMLDivElement::create(document))
, m_snapToLines(true)
, m_displayTreeShouldChange(true)
- , m_notifyRegion(true)
{
UseCounter::count(document, UseCounter::VTTCue);
}
@@ -500,11 +499,6 @@ void VTTCue::setRegionId(const String& regionId)
cueDidChange();
}
-void VTTCue::notifyRegionWhenRemovingDisplayTree(bool notifyRegion)
-{
- m_notifyRegion = notifyRegion;
-}
-
float VTTCue::calculateComputedLinePosition() const
{
// http://dev.w3.org/html5/webvtt/#dfn-text-track-cue-computed-line-position
@@ -849,9 +843,9 @@ PassRefPtrWillBeRawPtr<VTTCueBox> VTTCue::getDisplayTree()
return displayTree.release();
}
-void VTTCue::removeDisplayTree()
+void VTTCue::removeDisplayTree(RemovalNotification removalNotification)
{
- if (m_notifyRegion && track()->regions()) {
+ if (removalNotification == NotifyRegion && track()->regions()) {
// The region needs to be informed about the cue removal.
VTTRegion* region = track()->regions()->getRegionById(m_regionId);
if (region)
« no previous file with comments | « Source/core/html/track/vtt/VTTCue.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698