Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: Source/core/html/track/TextTrackCue.h

Issue 939193002: Remove TextTrackCue::notifyRegionWhenRemovingDisplayTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Hoist removeDisplayTree-call from setIsActive. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/track/CueTimeline.cpp ('k') | Source/core/html/track/TextTrackCue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/TextTrackCue.h
diff --git a/Source/core/html/track/TextTrackCue.h b/Source/core/html/track/TextTrackCue.h
index bc559bf6c1bbbffb601f32aa5e98ef3cdf5eeb2c..398a965d2b04ea0186d290b5e937d228f14eb782 100644
--- a/Source/core/html/track/TextTrackCue.h
+++ b/Source/core/html/track/TextTrackCue.h
@@ -77,15 +77,19 @@ public:
virtual bool dispatchEvent(PassRefPtrWillBeRawPtr<Event>) override;
bool isActive();
- void setIsActive(bool);
+ void setIsActive(bool active) { m_isActive = active; }
virtual void updateDisplay(HTMLDivElement& container) = 0;
// FIXME: Consider refactoring to eliminate or merge the following three members.
// https://code.google.com/p/chromium/issues/detail?id=322434
virtual void updateDisplayTree(double movieTime) = 0;
- virtual void removeDisplayTree() = 0;
- virtual void notifyRegionWhenRemovingDisplayTree(bool notifyRegion) = 0;
+
+ enum RemovalNotification {
+ DontNotifyRegion,
+ NotifyRegion
+ };
+ virtual void removeDisplayTree(RemovalNotification = NotifyRegion) = 0;
virtual const AtomicString& interfaceName() const override;
« no previous file with comments | « Source/core/html/track/CueTimeline.cpp ('k') | Source/core/html/track/TextTrackCue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698