Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 939103002: Do not playback existing commands for full deferred canvas writePixels (Closed)

Created:
5 years, 10 months ago by Kimmo Kinnunen
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Do not playback pending commands for full deferred canvas writePixels Do not playback pending commands for full deferred canvas writePixels. Changes the test to catch cases where discard is done without a snapshot. Committed: https://skia.googlesource.com/skia/+/8dcb8b04f80eff810e63c2696c01f6150d104109

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -36 lines) Patch
M src/utils/SkDeferredCanvas.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 1 2 chunks +68 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Kimmo Kinnunen
Changed in: https://codereview.chromium.org/180113010
5 years, 10 months ago (2015-02-19 14:39:49 UTC) #2
Justin Novosad
On 2015/02/19 14:39:49, Kimmo Kinnunen wrote: > Changed in: https://codereview.chromium.org/180113010 lgtm
5 years, 9 months ago (2015-03-17 15:20:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939103002/60001
5 years, 9 months ago (2015-03-23 09:12:09 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 09:18:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/8dcb8b04f80eff810e63c2696c01f6150d104109

Powered by Google App Engine
This is Rietveld 408576698