Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 180113010: Add SkCanvas::writePixels that takes info+pixels directly (Closed)

Created:
6 years, 9 months ago by reed1
Modified:
6 years, 9 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add SkCanvas::writePixels that takes info+pixels directly add corresponding methods to device (w/ diff name to avoid colliding with exising virtuals) BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13697

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 6

Patch Set 5 : #

Patch Set 6 : address cl comments from patchset #4 #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+493 lines, -93 lines) Patch
M bench/PremulAndUnpremulAlphaOpsBench.cpp View 1 2 3 4 3 chunks +9 lines, -2 lines 0 comments Download
M bench/WritePixelsBench.cpp View 1 2 3 4 3 chunks +30 lines, -26 lines 0 comments Download
M gyp/bench.gyp View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M gyp/bench.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M gyp/tests.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkBitmapDevice.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M include/core/SkCanvas.h View 1 2 3 4 5 3 chunks +32 lines, -3 lines 0 comments Download
M include/core/SkDevice.h View 1 2 3 4 5 3 chunks +13 lines, -1 line 0 comments Download
M include/gpu/SkGpuDevice.h View 1 2 chunks +4 lines, -5 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 2 chunks +91 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 3 4 5 2 chunks +57 lines, -0 lines 0 comments Download
M src/core/SkConfig8888.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/core/SkDevice.cpp View 1 2 3 4 5 6 1 chunk +24 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 chunks +21 lines, -0 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 2 3 4 5 6 chunks +25 lines, -6 lines 0 comments Download
M src/utils/SkGatherPixelRefsAndRects.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/utils/SkPictureUtils.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 1 2 3 4 9 chunks +30 lines, -7 lines 0 comments Download
M tests/PremulAlphaRoundTripTest.cpp View 1 2 chunks +53 lines, -32 lines 0 comments Download
M tests/WritePixelsTest.cpp View 1 3 chunks +9 lines, -6 lines 0 comments Download
A tools/sk_tool_utils.h View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A tools/sk_tool_utils.cpp View 1 2 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
reed1
6 years, 9 months ago (2014-03-05 20:49:36 UTC) #1
reed1
still todo: - add tests - prepare path to deprecate the old api that uses ...
6 years, 9 months ago (2014-03-05 20:50:51 UTC) #2
bsalomon
lgtm.. maybe the existing read/write tests can be extended to test the new APIs (and ...
6 years, 9 months ago (2014-03-05 21:08:31 UTC) #3
robertphillips
https://codereview.chromium.org/180113010/diff/1/include/core/SkCanvas.h File include/core/SkCanvas.h (right): https://codereview.chromium.org/180113010/diff/1/include/core/SkCanvas.h#newcode297 include/core/SkCanvas.h:297: * pixels, performing any colortype/alphatype transformations needed (in the ...
6 years, 9 months ago (2014-03-05 23:19:19 UTC) #4
reed1
Still looking unittest issue in DeferredCanvas, but PTAL btw - my read of chrome is ...
6 years, 9 months ago (2014-03-06 16:49:48 UTC) #5
bsalomon
https://codereview.chromium.org/180113010/diff/60001/include/core/SkCanvas.h File include/core/SkCanvas.h (right): https://codereview.chromium.org/180113010/diff/60001/include/core/SkCanvas.h#newcode282 include/core/SkCanvas.h:282: * SkPicture, writePixels() is ignored! DEPRECATED? https://codereview.chromium.org/180113010/diff/60001/src/core/SkCanvas.cpp File src/core/SkCanvas.cpp ...
6 years, 9 months ago (2014-03-06 17:48:11 UTC) #6
Justin Novosad
https://codereview.chromium.org/180113010/diff/60001/src/utils/SkDeferredCanvas.cpp File src/utils/SkDeferredCanvas.cpp (right): https://codereview.chromium.org/180113010/diff/60001/src/utils/SkDeferredCanvas.cpp#newcode519 src/utils/SkDeferredCanvas.cpp:519: if (info.width() == deviceInfo.width() && info.height() == deviceInfo.height()) { ...
6 years, 9 months ago (2014-03-06 17:57:24 UTC) #7
reed1
https://codereview.chromium.org/180113010/diff/60001/include/core/SkCanvas.h File include/core/SkCanvas.h (right): https://codereview.chromium.org/180113010/diff/60001/include/core/SkCanvas.h#newcode282 include/core/SkCanvas.h:282: * SkPicture, writePixels() is ignored! On 2014/03/06 17:48:12, bsalomon ...
6 years, 9 months ago (2014-03-06 20:21:29 UTC) #8
reed1
Note: I disabled 4 tests in DeferredCanvasTest. These (afaik) were looking for possible short-cuts in ...
6 years, 9 months ago (2014-03-06 20:39:17 UTC) #9
Justin Novosad
lgtm for the deferred canvas stuff
6 years, 9 months ago (2014-03-06 21:32:27 UTC) #10
bsalomon
On 2014/03/06 21:32:27, junov wrote: > lgtm for the deferred canvas stuff lgtm for the ...
6 years, 9 months ago (2014-03-06 21:59:52 UTC) #11
reed1
The CQ bit was checked by reed@google.com
6 years, 9 months ago (2014-03-06 22:14:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/180113010/110001
6 years, 9 months ago (2014-03-06 22:14:44 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 03:25:24 UTC) #14
Message was sent while issue was closed.
Change committed as 13697

Powered by Google App Engine
This is Rietveld 408576698