Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 939083002: Fix version handling for boolean groups. (Closed)

Created:
5 years, 10 months ago by qsr
Modified:
5 years, 10 months ago
Reviewers:
etiennej
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@fix_apk_update
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -7 lines) Patch
M mojo/public/python/mojo_bindings/descriptor.py View 6 chunks +25 lines, -5 lines 0 comments Download
M mojo/public/python/mojo_bindings/serialization.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
qsr
5 years, 10 months ago (2015-02-19 13:41:16 UTC) #1
etiennej
lgtm https://codereview.chromium.org/939083002/diff/1/mojo/public/python/mojo_bindings/reflection.py File mojo/public/python/mojo_bindings/reflection.py (right): https://codereview.chromium.org/939083002/diff/1/mojo/public/python/mojo_bindings/reflection.py#newcode277 mojo/public/python/mojo_bindings/reflection.py:277: def NewRequest(self): This is a welcome addition, even ...
5 years, 10 months ago (2015-02-19 13:50:37 UTC) #2
qsr
On 2015/02/19 13:50:37, etiennej wrote: > lgtm > > https://codereview.chromium.org/939083002/diff/1/mojo/public/python/mojo_bindings/reflection.py > File mojo/public/python/mojo_bindings/reflection.py (right): > ...
5 years, 10 months ago (2015-02-19 14:17:03 UTC) #3
qsr
5 years, 10 months ago (2015-02-19 14:18:39 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
774437ec4ed1ff58c74b61a304a6383686423771 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698